From: Mark Kettenis <kettenis@chello.nl>
To: marcel@xcllnt.net, kevinb@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] ia64-unknown-freebsd
Date: Thu, 25 Mar 2004 11:45:00 -0000 [thread overview]
Message-ID: <200403251145.i2PBjMUE000818@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <20040325091159.GB87599@dhcp01.pn.xcllnt.net> (message from Marcel Moolenaar on Thu, 25 Mar 2004 01:11:59 -0800)
Date: Thu, 25 Mar 2004 01:11:59 -0800
From: Marcel Moolenaar <marcel@xcllnt.net>
Marcel, do you have a copyright assignment with the FSF for GDB?
Without it we can't use your code :-(. Does this code give some
reasonable testsuite results? Does it support calling functions from
within GDB? I never got that working when I was hacking on this.
Kevin. What's the status of AIX on IA-64? Isn't it completely dead?
Anyway, Marcel, here are some hints:
* Get rid of the xm-fbsd.h file.
* For the nm-fbsd.h file, I recently factored out some common *BSD
things. Also, please move the shared library support stuff to
tm-fbsd.h. All you need there is to include "solib.h". The
inclusion of "elf/common.h" and the SVR4_SHARED_LIBS shouldn't be
necessary anymore. This also means you'll want to move solib.o and
solib-svr4.o from fbsd.mh to fbsd.mt. You can drop solib-legacy.o
if you add:
set_solib_svr4_fetch_link_map_offsets
(gdbarch, svr4_lp64_fetch_link_map_offsets);
to ia64-fbsd-tdep.c:ia64_fbsd_init_abi().
* The code that deals with the registers (taking apart `struct reg'
and `struct fpreg') shouldn't live in ia64-fbsd-nat.c, but in
ia64-fbs-tdep.c. This involves hard coding the offsets of the
various registers.
* There are various coding-style issues. Mostly this involves the
formatting of comments, but there are also GCC-isms like __inline
that will have to dissappear.
That said, I think you're on the right track with TARGET_OBJECT_DIRTY.
Mark
next prev parent reply other threads:[~2004-03-25 11:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-25 9:12 Marcel Moolenaar
2004-03-25 11:45 ` Mark Kettenis [this message]
2004-03-25 16:58 ` Marcel Moolenaar
2004-03-26 0:30 ` Andrew Cagney
2004-03-26 14:12 ` Kevin Buettner
2004-03-25 21:30 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200403251145.i2PBjMUE000818@elgar.kettenis.dyndns.org \
--to=kettenis@chello.nl \
--cc=gdb-patches@sources.redhat.com \
--cc=kevinb@redhat.com \
--cc=marcel@xcllnt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox