From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3734 invoked by alias); 25 Mar 2004 11:45:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3702 invoked from network); 25 Mar 2004 11:45:31 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.115.144) by sources.redhat.com with SMTP; 25 Mar 2004 11:45:31 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i2PBjNw2000363; Thu, 25 Mar 2004 12:45:23 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i2PBjNvw000821; Thu, 25 Mar 2004 12:45:23 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i2PBjMUE000818; Thu, 25 Mar 2004 12:45:22 +0100 (CET) Date: Thu, 25 Mar 2004 11:45:00 -0000 Message-Id: <200403251145.i2PBjMUE000818@elgar.kettenis.dyndns.org> From: Mark Kettenis To: marcel@xcllnt.net, kevinb@redhat.com CC: gdb-patches@sources.redhat.com In-reply-to: <20040325091159.GB87599@dhcp01.pn.xcllnt.net> (message from Marcel Moolenaar on Thu, 25 Mar 2004 01:11:59 -0800) Subject: Re: [PATCH] ia64-unknown-freebsd References: <20040325091159.GB87599@dhcp01.pn.xcllnt.net> X-SW-Source: 2004-03/txt/msg00607.txt.bz2 Date: Thu, 25 Mar 2004 01:11:59 -0800 From: Marcel Moolenaar Marcel, do you have a copyright assignment with the FSF for GDB? Without it we can't use your code :-(. Does this code give some reasonable testsuite results? Does it support calling functions from within GDB? I never got that working when I was hacking on this. Kevin. What's the status of AIX on IA-64? Isn't it completely dead? Anyway, Marcel, here are some hints: * Get rid of the xm-fbsd.h file. * For the nm-fbsd.h file, I recently factored out some common *BSD things. Also, please move the shared library support stuff to tm-fbsd.h. All you need there is to include "solib.h". The inclusion of "elf/common.h" and the SVR4_SHARED_LIBS shouldn't be necessary anymore. This also means you'll want to move solib.o and solib-svr4.o from fbsd.mh to fbsd.mt. You can drop solib-legacy.o if you add: set_solib_svr4_fetch_link_map_offsets (gdbarch, svr4_lp64_fetch_link_map_offsets); to ia64-fbsd-tdep.c:ia64_fbsd_init_abi(). * The code that deals with the registers (taking apart `struct reg' and `struct fpreg') shouldn't live in ia64-fbsd-nat.c, but in ia64-fbs-tdep.c. This involves hard coding the offsets of the various registers. * There are various coding-style issues. Mostly this involves the formatting of comments, but there are also GCC-isms like __inline that will have to dissappear. That said, I think you're on the right track with TARGET_OBJECT_DIRTY. Mark