Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [commit] Fix an off-by-one frame bug
@ 2004-03-17 23:45 Andrew Cagney
  2004-03-19  0:09 ` Andrew Cagney
  0 siblings, 1 reply; 2+ messages in thread
From: Andrew Cagney @ 2004-03-17 23:45 UTC (permalink / raw)
  To: gdb-patches

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

FYI,

Spotted this think-o.  It only affects an architecture part way through 
a frame conversion (which would explain why no one noticed).

committed,
Andrew

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 869 bytes --]

2004-03-17  Andrew Cagney  <cagney@redhat.com>

	* frame.c (legacy_get_prev_frame): Pass correct frame to
	frame_unwind_find_by_frame.

Index: frame.c
===================================================================
RCS file: /cvs/src/src/gdb/frame.c,v
retrieving revision 1.162
diff -u -r1.162 frame.c
--- frame.c	16 Feb 2004 21:49:21 -0000	1.162
+++ frame.c	17 Mar 2004 23:42:39 -0000
@@ -1493,7 +1493,7 @@
              to the new frame code.  Implement FRAME_CHAIN the way the
              new frame will.  */
 	  /* Find PREV frame's unwinder.  */
-	  prev->unwind = frame_unwind_find_by_frame (this_frame->next);
+	  prev->unwind = frame_unwind_find_by_frame (this_frame);
 	  /* FIXME: cagney/2003-04-02: Rather than storing the frame's
 	     type in the frame, the unwinder's type should be returned
 	     directly.  Unfortunately, legacy code, called by

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [commit] Fix an off-by-one frame bug
  2004-03-17 23:45 [commit] Fix an off-by-one frame bug Andrew Cagney
@ 2004-03-19  0:09 ` Andrew Cagney
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cagney @ 2004-03-19  0:09 UTC (permalink / raw)
  To: gdb-patches

[-- Attachment #1: Type: text/plain, Size: 159 bytes --]

FYI,

Spotted this think-o.  It only affects an architecture part way through 
a frame conversion (which would explain why no one noticed).

committed,
Andrew

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 869 bytes --]

2004-03-17  Andrew Cagney  <cagney@redhat.com>

	* frame.c (legacy_get_prev_frame): Pass correct frame to
	frame_unwind_find_by_frame.

Index: frame.c
===================================================================
RCS file: /cvs/src/src/gdb/frame.c,v
retrieving revision 1.162
diff -u -r1.162 frame.c
--- frame.c	16 Feb 2004 21:49:21 -0000	1.162
+++ frame.c	17 Mar 2004 23:42:39 -0000
@@ -1493,7 +1493,7 @@
              to the new frame code.  Implement FRAME_CHAIN the way the
              new frame will.  */
 	  /* Find PREV frame's unwinder.  */
-	  prev->unwind = frame_unwind_find_by_frame (this_frame->next);
+	  prev->unwind = frame_unwind_find_by_frame (this_frame);
 	  /* FIXME: cagney/2003-04-02: Rather than storing the frame's
 	     type in the frame, the unwinder's type should be returned
 	     directly.  Unfortunately, legacy code, called by

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-03-17 23:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-03-17 23:45 [commit] Fix an off-by-one frame bug Andrew Cagney
2004-03-19  0:09 ` Andrew Cagney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox