From: Daniel Jacobowitz <drow@false.org>
To: Orjan Friberg <orjan.friberg@axis.com>
Cc: gdb-patches@sources.redhat.com,
Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
Subject: Re: [CRIS] dwarf2 frame sniffer problem?
Date: Tue, 16 Mar 2004 19:13:00 -0000 [thread overview]
Message-ID: <20040316191301.GA13244@nevyn.them.org> (raw)
In-Reply-To: <40572AA8.5040406@axis.com>
On Tue, Mar 16, 2004 at 05:26:16PM +0100, Orjan Friberg wrote:
> Daniel Jacobowitz wrote:
> >
> >I see that your GCC port uses textual prologues. As it happens, I just
> >implemented dwarf generation for that mechanism (for Thumb), so I know
> >how it's supposed to work. Here's your problem. First you have:
> >
> > /* FIXME: Slightly redundant calculation, as we do the same in
> > pieces below. This offset must be the total adjustment of the
> > stack-pointer. We can then def_cfa call at the end of this
> > function with the current implementation of execute_cfa_insn, but
> > that wouldn't really be clean. */
> >
> > cfa_label = dwarf2out_cfi_label ();
> > dwarf2out_def_cfa (cfa_label, cfa_reg, cfa_offset);
> >
> >but that label is at the beginning of the function, so this is
> >incorrect. That's not what the CFA is at the beginning of the
> >function.
>
> Would emitting that label *after* the prologue be an option (i.e.
> leaving us without dwarf2 information while still in the prologue)?
Nope. Then when you step into the prologue (i.e. "step over") unwind
information will be incorrect.
I recommend taking a look at the patch where I implemented this for
Thumb, or at the m68k implementation.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
WARNING: multiple messages have this Message-ID
From: Daniel Jacobowitz <drow@false.org>
To: Orjan Friberg <orjan.friberg@axis.com>
Cc: gdb-patches@sources.redhat.com,
Hans-Peter Nilsson <hans-peter.nilsson@axis.com>
Subject: Re: [CRIS] dwarf2 frame sniffer problem?
Date: Fri, 19 Mar 2004 00:09:00 -0000 [thread overview]
Message-ID: <20040316191301.GA13244@nevyn.them.org> (raw)
Message-ID: <20040319000900.rss05bWuWpOkzBXUj4xyBIv9CLTyzn6_cN2N5LTPuJw@z> (raw)
In-Reply-To: <40572AA8.5040406@axis.com>
On Tue, Mar 16, 2004 at 05:26:16PM +0100, Orjan Friberg wrote:
> Daniel Jacobowitz wrote:
> >
> >I see that your GCC port uses textual prologues. As it happens, I just
> >implemented dwarf generation for that mechanism (for Thumb), so I know
> >how it's supposed to work. Here's your problem. First you have:
> >
> > /* FIXME: Slightly redundant calculation, as we do the same in
> > pieces below. This offset must be the total adjustment of the
> > stack-pointer. We can then def_cfa call at the end of this
> > function with the current implementation of execute_cfa_insn, but
> > that wouldn't really be clean. */
> >
> > cfa_label = dwarf2out_cfi_label ();
> > dwarf2out_def_cfa (cfa_label, cfa_reg, cfa_offset);
> >
> >but that label is at the beginning of the function, so this is
> >incorrect. That's not what the CFA is at the beginning of the
> >function.
>
> Would emitting that label *after* the prologue be an option (i.e.
> leaving us without dwarf2 information while still in the prologue)?
Nope. Then when you step into the prologue (i.e. "step over") unwind
information will be incorrect.
I recommend taking a look at the patch where I implemented this for
Thumb, or at the m68k implementation.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2004-03-16 19:13 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-10 16:53 Orjan Friberg
2004-03-10 16:59 ` Daniel Jacobowitz
2004-03-19 0:09 ` Orjan Friberg
2004-03-11 14:09 ` Orjan Friberg
2004-03-11 15:55 ` Orjan Friberg
2004-03-11 17:05 ` Andrew Cagney
2004-03-19 0:09 ` Orjan Friberg
2004-03-12 12:00 ` Orjan Friberg
2004-03-19 0:09 ` Andrew Cagney
2004-03-11 17:11 ` Daniel Jacobowitz
2004-03-12 10:23 ` Orjan Friberg
2004-03-19 0:09 ` Orjan Friberg
2004-03-12 15:38 ` Orjan Friberg
2004-03-19 0:09 ` Orjan Friberg
2004-03-12 13:50 ` Orjan Friberg
2004-03-19 0:09 ` Orjan Friberg
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-12 15:38 ` Daniel Jacobowitz
2004-03-15 10:19 ` Orjan Friberg
2004-03-19 0:09 ` Orjan Friberg
2004-03-16 16:26 ` Orjan Friberg
2004-03-16 19:13 ` Daniel Jacobowitz [this message]
2004-03-16 20:51 ` Hans-Peter Nilsson
2004-03-16 22:27 ` Daniel Jacobowitz
2004-03-16 23:38 ` Hans-Peter Nilsson
2004-03-16 23:58 ` Daniel Jacobowitz
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-19 0:09 ` Hans-Peter Nilsson
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-19 0:09 ` Hans-Peter Nilsson
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-19 0:09 ` Orjan Friberg
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-19 0:09 ` Orjan Friberg
2004-03-19 0:09 ` Daniel Jacobowitz
2004-03-19 0:09 ` Orjan Friberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040316191301.GA13244@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
--cc=hans-peter.nilsson@axis.com \
--cc=orjan.friberg@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox