From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sources.redhat.com
Subject: [patch] Remove an 'extern int errno'
Date: Fri, 12 Mar 2004 20:55:00 -0000 [thread overview]
Message-ID: <20040312205517.GA944@nevyn.them.org> (raw)
This is harmless, since <errno.h> was included by server.h anyway; but the
'extern int errno' declaration is incorrect and should always be removed in
favor of <errno.h>. Committed to HEAD and 6.1.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
2004-03-12 Daniel Jacobowitz <drow@mvista.com>
* linux-low.c: Include <errno.h>. Remove extern declaration of
errno.
Index: linux-low.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/linux-low.c,v
retrieving revision 1.30
diff -u -p -r1.30 linux-low.c
--- linux-low.c 5 Mar 2004 03:43:19 -0000 1.30
+++ linux-low.c 12 Mar 2004 20:49:24 -0000
@@ -34,6 +34,7 @@
#include <string.h>
#include <stdlib.h>
#include <unistd.h>
+#include <errno.h>
/* ``all_threads'' is keyed by the LWP ID - it should be the thread ID instead,
however. This requires changing the ID in place when we go from !using_threads
@@ -68,8 +69,6 @@ struct pending_signals
#ifdef HAVE_LINUX_REGSETS
static int use_regsets_p = 1;
#endif
-
-extern int errno;
int debug_threads = 0;
WARNING: multiple messages have this Message-ID
From: Daniel Jacobowitz <drow@false.org>
To: gdb-patches@sources.redhat.com
Subject: [patch] Remove an 'extern int errno'
Date: Fri, 19 Mar 2004 00:09:00 -0000 [thread overview]
Message-ID: <20040312205517.GA944@nevyn.them.org> (raw)
Message-ID: <20040319000900.5zDpPbGy1Q1zJgf48XPFagSrWQbL1AARru2ogKZgOQM@z> (raw)
This is harmless, since <errno.h> was included by server.h anyway; but the
'extern int errno' declaration is incorrect and should always be removed in
favor of <errno.h>. Committed to HEAD and 6.1.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
2004-03-12 Daniel Jacobowitz <drow@mvista.com>
* linux-low.c: Include <errno.h>. Remove extern declaration of
errno.
Index: linux-low.c
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/linux-low.c,v
retrieving revision 1.30
diff -u -p -r1.30 linux-low.c
--- linux-low.c 5 Mar 2004 03:43:19 -0000 1.30
+++ linux-low.c 12 Mar 2004 20:49:24 -0000
@@ -34,6 +34,7 @@
#include <string.h>
#include <stdlib.h>
#include <unistd.h>
+#include <errno.h>
/* ``all_threads'' is keyed by the LWP ID - it should be the thread ID instead,
however. This requires changing the ID in place when we go from !using_threads
@@ -68,8 +69,6 @@ struct pending_signals
#ifdef HAVE_LINUX_REGSETS
static int use_regsets_p = 1;
#endif
-
-extern int errno;
int debug_threads = 0;
next reply other threads:[~2004-03-12 20:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-12 20:55 Daniel Jacobowitz [this message]
2004-03-19 0:09 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040312205517.GA944@nevyn.them.org \
--to=drow@false.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox