From: Joel Brobecker <brobecker@gnat.com>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [commit/pa] missing "break"
Date: Fri, 19 Mar 2004 00:09:00 -0000 [thread overview]
Message-ID: <20040308225112.GY1226@gnat.com> (raw)
In-Reply-To: <404B7677.1040904@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 593 bytes --]
> Oops, deleted slightly to much code when enabling enabling 64-bit ABI.
Just for the record, the actual patch was not:
> 2004-03-07 Andrew Cagney <cagney@redhat.com>
>
> * hppa-tdep.c (pa_do_registers_info, pa_do_strcat_registers_info)
> (pa_print_registers, pa_print_fp_reg, pa_strcat_registers)
> (pa_strcat_fp_reg, pa_register_look_aside): Delete.
> * config/pa/tm-hppa.h (DEPRECATED_DO_REGISTERS_INFO)
> (pa_do_registers_info): Delete.
But rather:
2004-03-07 Andrew Cagney <cagney@redhat.com>
* hppa-tdep.c (hppa_gdbarch_init): Add missing "break".
:-)
--
Joel
[-- Attachment #2: hppa-tdep.c.diff --]
[-- Type: text/plain, Size: 550 bytes --]
Index: hppa-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/hppa-tdep.c,v
retrieving revision 1.134
retrieving revision 1.135
diff -u -p -r1.134 -r1.135
--- hppa-tdep.c 7 Mar 2004 19:00:42 -0000 1.134
+++ hppa-tdep.c 7 Mar 2004 19:21:13 -0000 1.135
@@ -3363,6 +3363,7 @@ hppa_gdbarch_init (struct gdbarch_info i
break;
case 8:
set_gdbarch_return_value (gdbarch, hppa64_return_value);
+ break;
default:
internal_error (__FILE__, __LINE__, "bad switch");
}
WARNING: multiple messages have this Message-ID
From: Joel Brobecker <brobecker@gnat.com>
To: Andrew Cagney <cagney@gnu.org>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [commit/pa] missing "break"
Date: Mon, 08 Mar 2004 22:51:00 -0000 [thread overview]
Message-ID: <20040308225112.GY1226@gnat.com> (raw)
Message-ID: <20040308225100.NwJCDuDMGWdQMraR_sZdhJO6oYYCqS8a64XTwqwRwuA@z> (raw)
In-Reply-To: <404B7677.1040904@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 593 bytes --]
> Oops, deleted slightly to much code when enabling enabling 64-bit ABI.
Just for the record, the actual patch was not:
> 2004-03-07 Andrew Cagney <cagney@redhat.com>
>
> * hppa-tdep.c (pa_do_registers_info, pa_do_strcat_registers_info)
> (pa_print_registers, pa_print_fp_reg, pa_strcat_registers)
> (pa_strcat_fp_reg, pa_register_look_aside): Delete.
> * config/pa/tm-hppa.h (DEPRECATED_DO_REGISTERS_INFO)
> (pa_do_registers_info): Delete.
But rather:
2004-03-07 Andrew Cagney <cagney@redhat.com>
* hppa-tdep.c (hppa_gdbarch_init): Add missing "break".
:-)
--
Joel
[-- Attachment #2: hppa-tdep.c.diff --]
[-- Type: text/plain, Size: 550 bytes --]
Index: hppa-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/hppa-tdep.c,v
retrieving revision 1.134
retrieving revision 1.135
diff -u -p -r1.134 -r1.135
--- hppa-tdep.c 7 Mar 2004 19:00:42 -0000 1.134
+++ hppa-tdep.c 7 Mar 2004 19:21:13 -0000 1.135
@@ -3363,6 +3363,7 @@ hppa_gdbarch_init (struct gdbarch_info i
break;
case 8:
set_gdbarch_return_value (gdbarch, hppa64_return_value);
+ break;
default:
internal_error (__FILE__, __LINE__, "bad switch");
}
next prev parent reply other threads:[~2004-03-08 22:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-19 0:09 Andrew Cagney
2004-03-07 19:22 ` Andrew Cagney
2004-03-19 0:09 ` Joel Brobecker [this message]
2004-03-08 22:51 ` Joel Brobecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040308225112.GY1226@gnat.com \
--to=brobecker@gnat.com \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox