From: Elena Zannoni <ezannoni@redhat.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [RFA] sh-tdep.c: Fix erroneus register skipping in sh_print_registers_info
Date: Fri, 05 Mar 2004 22:36:00 -0000 [thread overview]
Message-ID: <16456.65466.312420.773141@localhost.redhat.com> (raw)
Message-ID: <20040305223600.g-f9vs88YHinBZZWnNVZvjfPsXxBFdbtWEIviHZq4Rw@z> (raw)
In-Reply-To: <20040218135942.GA29776@cygbert.vinschen.de>
Corinna Vinschen writes:
> Hi,
>
> the below patch fixes a long standing bug in sh_print_registers_info.
> When the print loop encounters a float type register and fpregs is
> not set, then the loop counter (regnum) is not just incremented by
> one, but instead it's incremented by FP_LAST_REGNUM - FP0_REGNUM.
>
> The problem with this is, that FPUL is also a float type register.
> FPUL is two register numbers below FP0_REGNUM. So when the loop
> arrives at FPUL, it skips the next 16 registers. The next evaluated
> register then (fr14) is still a float type register, so the loop
> skips again 16 registers. As a result, the register set is never
> printed completely when calling `info registers'.
>
> The below patch fixes that and shortens the code slightly by using
> a "for" loop instead of "while".
>
>
> Corinna
>
>
> ChangeLog:
>
> * sh-tdep.c (sh_print_registers_info): Use for loop.
> Don't skip multiple registers when a float register is encountered.
>
ok
next prev parent reply other threads:[~2004-03-05 22:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-18 14:00 Corinna Vinschen
2004-02-26 9:49 ` Corinna Vinschen
2004-03-19 0:09 ` Elena Zannoni [this message]
2004-03-05 22:36 ` Elena Zannoni
2004-03-08 10:18 ` Corinna Vinschen
2004-03-19 0:09 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16456.65466.312420.773141@localhost.redhat.com \
--to=ezannoni@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox