Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA] Fix build failure on AiX...
Date: Mon, 01 Mar 2004 20:08:00 -0000	[thread overview]
Message-ID: <20040301200835.GL1051@gnat.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 548 bytes --]

This is a following on the following change:

    http://sources.redhat.com/ml/gdb-patches/2004-03/msg00000.html

GDB fails to build on AiX because we're trying to dereference an
opaque structure (struct frame_info).

I suggest the following patch to fix the build failure:

        * rs6000-tdep.c (rs6000_init_frame_pc_first): Fix compilation failure.

OK to apply? (it may appear obvious to the usual maintainers, but the
frame stuff still makes me nervous sometimes, especially the easy
confusion with next, prev, inner most, etc...)

-- 
Joel

[-- Attachment #2: rs6000-tdep.c --]
[-- Type: text/plain, Size: 773 bytes --]

Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.182
diff -u -p -r1.182 rs6000-tdep.c
--- rs6000-tdep.c	1 Mar 2004 00:50:56 -0000	1.182
+++ rs6000-tdep.c	1 Mar 2004 20:02:05 -0000
@@ -213,8 +213,10 @@ rs6000_frame_init_saved_regs (struct fra
 static CORE_ADDR
 rs6000_init_frame_pc_first (int fromleaf, struct frame_info *prev)
 {
-  return (fromleaf ? DEPRECATED_SAVED_PC_AFTER_CALL (prev->next)
-	  : prev->next ? DEPRECATED_FRAME_SAVED_PC (prev->next) : read_pc ());
+  struct frame_info* next = get_next_frame (prev);
+
+  return (fromleaf ? DEPRECATED_SAVED_PC_AFTER_CALL (next)
+	  : next ? DEPRECATED_FRAME_SAVED_PC (next) : read_pc ());
 }
 
 static CORE_ADDR

WARNING: multiple messages have this Message-ID
From: Joel Brobecker <brobecker@gnat.com>
To: gdb-patches@sources.redhat.com
Subject: [RFA] Fix build failure on AiX...
Date: Fri, 19 Mar 2004 00:09:00 -0000	[thread overview]
Message-ID: <20040301200835.GL1051@gnat.com> (raw)
Message-ID: <20040319000900.fjB7uXqytD9eGKHQUttvaSvn_MoYoKP0QEwe18vrGJE@z> (raw)

[-- Attachment #1: Type: text/plain, Size: 548 bytes --]

This is a following on the following change:

    http://sources.redhat.com/ml/gdb-patches/2004-03/msg00000.html

GDB fails to build on AiX because we're trying to dereference an
opaque structure (struct frame_info).

I suggest the following patch to fix the build failure:

        * rs6000-tdep.c (rs6000_init_frame_pc_first): Fix compilation failure.

OK to apply? (it may appear obvious to the usual maintainers, but the
frame stuff still makes me nervous sometimes, especially the easy
confusion with next, prev, inner most, etc...)

-- 
Joel

[-- Attachment #2: rs6000-tdep.c --]
[-- Type: text/plain, Size: 773 bytes --]

Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.182
diff -u -p -r1.182 rs6000-tdep.c
--- rs6000-tdep.c	1 Mar 2004 00:50:56 -0000	1.182
+++ rs6000-tdep.c	1 Mar 2004 20:02:05 -0000
@@ -213,8 +213,10 @@ rs6000_frame_init_saved_regs (struct fra
 static CORE_ADDR
 rs6000_init_frame_pc_first (int fromleaf, struct frame_info *prev)
 {
-  return (fromleaf ? DEPRECATED_SAVED_PC_AFTER_CALL (prev->next)
-	  : prev->next ? DEPRECATED_FRAME_SAVED_PC (prev->next) : read_pc ());
+  struct frame_info* next = get_next_frame (prev);
+
+  return (fromleaf ? DEPRECATED_SAVED_PC_AFTER_CALL (next)
+	  : next ? DEPRECATED_FRAME_SAVED_PC (next) : read_pc ());
 }
 
 static CORE_ADDR

             reply	other threads:[~2004-03-01 20:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-03-01 20:08 Joel Brobecker [this message]
2004-03-19  0:09 ` Joel Brobecker
2004-03-19  0:09 ` Andrew Cagney
2004-03-02  2:22   ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040301200835.GL1051@gnat.com \
    --to=brobecker@gnat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox