Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [patch/gdbserver] Update current inferior when using vCont
@ 2004-02-28 18:24 Daniel Jacobowitz
  2004-02-29 16:49 ` Daniel Jacobowitz
  0 siblings, 1 reply; 2+ messages in thread
From: Daniel Jacobowitz @ 2004-02-28 18:24 UTC (permalink / raw)
  To: gdb-patches

Extensive testing on a software-single-step target using vCont turned up a
problem that testing on x86 didn't - not surprising, since gdbserver is
stressed much harder in this case.  By not calling set_desired_inferior after
setting cont_thread, we could end up sending signals to the wrong thread on
an interrupt from the client.

Will commit in a bit.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer

2004-02-28  Daniel Jacobowitz  <drow@mvista.com>

	* server.c (handle_v_cont): Call set_desired_inferior.

Index: gdb/gdbserver/server.c
===================================================================
RCS file: /big/fsf/rsync/src-cvs/src/gdb/gdbserver/server.c,v
retrieving revision 1.16
diff -u -p -r1.16 server.c
--- gdb/gdbserver/server.c	13 Oct 2003 16:17:21 -0000	1.16
+++ gdb/gdbserver/server.c	28 Feb 2004 03:06:13 -0000
@@ -213,6 +215,7 @@ handle_v_cont (char *own_buf, char *stat
     cont_thread = resume_info[0].thread;
   else
     cont_thread = -1;
+  set_desired_inferior (0);
 
   (*the_target->resume) (resume_info);
 


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch/gdbserver] Update current inferior when using vCont
  2004-02-28 18:24 [patch/gdbserver] Update current inferior when using vCont Daniel Jacobowitz
@ 2004-02-29 16:49 ` Daniel Jacobowitz
  0 siblings, 0 replies; 2+ messages in thread
From: Daniel Jacobowitz @ 2004-02-29 16:49 UTC (permalink / raw)
  To: gdb-patches

On Sat, Feb 28, 2004 at 01:24:39PM -0500, Daniel Jacobowitz wrote:
> Extensive testing on a software-single-step target using vCont turned up a
> problem that testing on x86 didn't - not surprising, since gdbserver is
> stressed much harder in this case.  By not calling set_desired_inferior after
> setting cont_thread, we could end up sending signals to the wrong thread on
> an interrupt from the client.
> 
> Will commit in a bit.

> 2004-02-28  Daniel Jacobowitz  <drow@mvista.com>
> 
> 	* server.c (handle_v_cont): Call set_desired_inferior.

I've committed this to HEAD.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-02-29 16:49 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-02-28 18:24 [patch/gdbserver] Update current inferior when using vCont Daniel Jacobowitz
2004-02-29 16:49 ` Daniel Jacobowitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox