Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <kettenis@chello.nl>
To: ac131313@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa:amd64] Fetch 32-bit thread area
Date: Sat, 28 Feb 2004 11:51:00 -0000	[thread overview]
Message-ID: <200402281151.i1SBpN4u000732@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <403E9C5F.2050803@redhat.com> (message from Andrew Cagney on Thu, 26 Feb 2004 20:24:47 -0500)

   Date: Thu, 26 Feb 2004 20:24:47 -0500
   From: Andrew Cagney <ac131313@redhat.com>

   Hello,

   This modifies the amd64 code so that, when 32-bit, it fetches the 32-bit 
   thread area register (I think this has been posted before?).

Why #if 0 ... #else ... #endif?

Anyway, I'm not really happy with the 

   switch (TARGET_ARCHITECTURE->mach)

construction.  The other AMD64 native code uses an

   if (gdbarch_ptr_bit (current_gdbarch) == 32)

to distinguish between 32-bit and 64-bit code.  While this may not be
completely correct (someone might come up with a native AMD64 ABI with
32-bit pointers), I'd rather not use multiple variations of the
32-bit/64-bit check in the code.

Mark


  reply	other threads:[~2004-02-28 11:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-27  1:24 Andrew Cagney
2004-02-28 11:51 ` Mark Kettenis [this message]
2004-02-28 15:22   ` Andrew Cagney
2004-02-28 17:37     ` Mark Kettenis
2004-02-28 19:40       ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200402281151.i1SBpN4u000732@elgar.kettenis.dyndns.org \
    --to=kettenis@chello.nl \
    --cc=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox