From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 11312 invoked by alias); 28 Feb 2004 11:51:36 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 11303 invoked from network); 28 Feb 2004 11:51:35 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.115.144) by sources.redhat.com with SMTP; 28 Feb 2004 11:51:35 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i1SBpOoq000353; Sat, 28 Feb 2004 12:51:24 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i1SBpObh000735; Sat, 28 Feb 2004 12:51:24 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i1SBpN4u000732; Sat, 28 Feb 2004 12:51:23 +0100 (CET) Date: Sat, 28 Feb 2004 11:51:00 -0000 Message-Id: <200402281151.i1SBpN4u000732@elgar.kettenis.dyndns.org> From: Mark Kettenis To: ac131313@redhat.com CC: gdb-patches@sources.redhat.com In-reply-to: <403E9C5F.2050803@redhat.com> (message from Andrew Cagney on Thu, 26 Feb 2004 20:24:47 -0500) Subject: Re: [rfa:amd64] Fetch 32-bit thread area References: <403E9C5F.2050803@redhat.com> X-SW-Source: 2004-02/txt/msg00818.txt.bz2 Date: Thu, 26 Feb 2004 20:24:47 -0500 From: Andrew Cagney Hello, This modifies the amd64 code so that, when 32-bit, it fetches the 32-bit thread area register (I think this has been posted before?). Why #if 0 ... #else ... #endif? Anyway, I'm not really happy with the switch (TARGET_ARCHITECTURE->mach) construction. The other AMD64 native code uses an if (gdbarch_ptr_bit (current_gdbarch) == 32) to distinguish between 32-bit and 64-bit code. While this may not be completely correct (someone might come up with a native AMD64 ABI with 32-bit pointers), I'd rather not use multiple variations of the 32-bit/64-bit check in the code. Mark