Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: fnf@redhat.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Handle unsupported "-shared" in gdb1555.exp test
Date: Wed, 25 Feb 2004 05:19:00 -0000	[thread overview]
Message-ID: <20040225051910.GA29717@nevyn.them.org> (raw)
In-Reply-To: <200402242157.59177.fnf@ninemoons.com>

On Tue, Feb 24, 2004 at 09:57:59PM -0700, Fred Fish wrote:
> There are 8 gdb tests that attempt to create a shared file using the
> "-shared" option:
> 
> 	gdb.base/gdb1555.exp
> 	gdb.base/pending.exp
> 	gdb.base/shlib-call.exp
> 	gdb.base/shreloc.exp:51
> 	gdb.base/so-impl-ld.exp
> 	gdb.base/so-indr-cl.exp
> 	gdb.base/solib.exp:101
> 	gdb.threads/tls-shared.exp
> 
> All of them, with the exception of gdb1555.exp and tls-shared.exp,
> first do some test to see if this is expected to work for the target.

This suggests that we need code in lib/gdb.exp to:
  - check whether shared library tests should be run
  - build shared libraries

> I propose that the gdb1555.exp test use the "isnative" check.
> Attached is a patch for review and comment.

Please don't.  I run cross-debugger tests which should test shared
library support on a regular basis.  I know this disagrees with prior
art in the testsuite, but I would prefer not to propogate it further.

How about something like:
proc gdb_compile_solib { whatever } {
  if {[istarget whatever]} {
    return -1
  }
  whatever
}

and using that to issue an unsupported (or silently return, I don't
know which is the accepted practice).

An alternative would be inclusive lists: {[istarget *-*-linux*] ||
[istarget *-*-bsd*] || ...} and so on as we teach the function how to
build shared libraries in different settings.  This might be the best
idea.


It is at this point that in any conversation about building shared
librares that someone should normally suggest making the testsuite use
libtool.  I give advance warning that I will do my worst to anyone who
makes such a suggestion.  Libtool is a disgusting pile of dung.  That's
my opinion and I'll stand by it.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


      reply	other threads:[~2004-02-25  5:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-25  4:58 Fred Fish
2004-02-25  5:19 ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040225051910.GA29717@nevyn.them.org \
    --to=drow@false.org \
    --cc=fnf@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox