Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Fred Fish <fnf@ninemoons.com>
To: gdb-patches@sources.redhat.com
Cc: fnf@redhat.com
Subject: [RFA] Handle unsupported "-shared" in gdb1555.exp test
Date: Wed, 25 Feb 2004 04:58:00 -0000	[thread overview]
Message-ID: <200402242157.59177.fnf@ninemoons.com> (raw)

There are 8 gdb tests that attempt to create a shared file using the
"-shared" option:

	gdb.base/gdb1555.exp
	gdb.base/pending.exp
	gdb.base/shlib-call.exp
	gdb.base/shreloc.exp:51
	gdb.base/so-impl-ld.exp
	gdb.base/so-indr-cl.exp
	gdb.base/solib.exp:101
	gdb.threads/tls-shared.exp

All of them, with the exception of gdb1555.exp and tls-shared.exp,
first do some test to see if this is expected to work for the target.

The shreloc.exp test uses:

	if {[istarget *-elf*] || [istarget *-coff] || [istarget *-aout]} then {
	    verbose "test skipped - shared object files not supported by this target."
	    return 0
	}

The tls-shared.exp test actually tries to run the compile, but it uses
a special version of gdb_compile that doesn't pass on a link failure
to the user output.

The rest of the tests use:

	# are we on a target board?
	if ![isnative] then {
	    return 0
	}

Since gdb1555.exp does nothing to avoid or hide link failures with
-shared the following type of message can appear in the user output
for targets where -shared isn't supported, such as sh-elf:

  Running /src/sourceware/gdb/src/gdb/testsuite/gdb.base/gdb1555.exp ...
  gdb compile failed, /links1/usr/local/sourceware/bin/../lib/gcc/sh-elf/3.5.0/../../../../sh-elf/bin/ld: warning: cannot find entry symbol start; defaulting to 0000000000001038

I propose that the gdb1555.exp test use the "isnative" check.
Attached is a patch for review and comment.

-Fred


2004-02-24  Fred Fish  <fnf@redhat.com>

	* gdb.base/gdb1555.exp: Skip test if not a native target.

Index: gdb.base/gdb1555.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/gdb1555.exp,v
retrieving revision 1.1
diff -c -p -r1.1 gdb1555.exp
*** gdb.base/gdb1555.exp	18 Feb 2004 03:35:08 -0000	1.1
--- gdb.base/gdb1555.exp	25 Feb 2004 04:40:38 -0000
*************** if $tracelevel then {
*** 25,30 ****
--- 25,35 ----
      strace $tracelevel
  }
  
+ # are we on a target board?
+ if ![isnative] then {
+     return 0
+ }
+ 
  set testfile gdb1555-main
  set libfile gdb1555
  set srcfile ${testfile}.c



             reply	other threads:[~2004-02-25  4:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-25  4:58 Fred Fish [this message]
2004-02-25  5:19 ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200402242157.59177.fnf@ninemoons.com \
    --to=fnf@ninemoons.com \
    --cc=fnf@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox