Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@false.org>
To: Eli Zaretskii <eliz@elta.co.il>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [intercu] Handle simple DIEs pre-emptively
Date: Sun, 22 Feb 2004 06:04:00 -0000	[thread overview]
Message-ID: <20040222060424.GA13959@nevyn.them.org> (raw)
In-Reply-To: <uu11jejmj.fsf@elta.co.il>

On Sun, Feb 22, 2004 at 08:03:16AM +0200, Eli Zaretskii wrote:
> > Date: Sat, 21 Feb 2004 20:01:17 -0500
> > From: Daniel Jacobowitz <drow@false.org>
> > +
> > +      /* This two-pass algorithm for processing partial symbols has a high
> > +	 cost in cache pressure.  Thus, handle some trivial cases here
> > +	 which cover the majority of C partial symbols.  DIEs which
> > +         neither have specification tags in them, nor could have specification
> > +         tags elsewhere pointing at them, can simply be processed and
> > +	 discarded.
> > +
> > +	 This segment is also optional; scan_partial_symbols and
> > +	 add_partial_symbol will handle these DIEs if we simply chain
> > +	 them in normally.  When compilers which do not emit large
> > +         quantities of duplicate debug information are more common,
> > +         this code can probably be removed.  */
> 
> More nit-picking: please use TABs and spaces consistently here.
> "M-x tabify" is your friend.

Actually, I blame Emacs for this one - when I justify (M-q) it plays
havoc with my tabbing, and is otherwise inconsistent.  This file could
use some serious tabification; I'll do it in a separate pass, later.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2004-02-22  6:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-22  1:01 Daniel Jacobowitz
2004-02-22  6:01 ` Eli Zaretskii
2004-02-22  6:04   ` Daniel Jacobowitz [this message]
2004-02-22  6:41     ` Eli Zaretskii
2004-02-22  6:48       ` Daniel Jacobowitz
2004-02-22 14:25         ` Eli Zaretskii
2004-02-22 21:32           ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040222060424.GA13959@nevyn.them.org \
    --to=drow@false.org \
    --cc=eliz@elta.co.il \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox