From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21122 invoked by alias); 22 Feb 2004 06:04:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21114 invoked from network); 22 Feb 2004 06:04:25 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 22 Feb 2004 06:04:25 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1Aumj2-0003eK-P9; Sun, 22 Feb 2004 01:04:24 -0500 Date: Sun, 22 Feb 2004 06:04:00 -0000 From: Daniel Jacobowitz To: Eli Zaretskii Cc: gdb-patches@sources.redhat.com Subject: Re: [intercu] Handle simple DIEs pre-emptively Message-ID: <20040222060424.GA13959@nevyn.them.org> Mail-Followup-To: Eli Zaretskii , gdb-patches@sources.redhat.com References: <20040222010117.GA13487@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.1i X-SW-Source: 2004-02/txt/msg00596.txt.bz2 On Sun, Feb 22, 2004 at 08:03:16AM +0200, Eli Zaretskii wrote: > > Date: Sat, 21 Feb 2004 20:01:17 -0500 > > From: Daniel Jacobowitz > > + > > + /* This two-pass algorithm for processing partial symbols has a high > > + cost in cache pressure. Thus, handle some trivial cases here > > + which cover the majority of C partial symbols. DIEs which > > + neither have specification tags in them, nor could have specification > > + tags elsewhere pointing at them, can simply be processed and > > + discarded. > > + > > + This segment is also optional; scan_partial_symbols and > > + add_partial_symbol will handle these DIEs if we simply chain > > + them in normally. When compilers which do not emit large > > + quantities of duplicate debug information are more common, > > + this code can probably be removed. */ > > More nit-picking: please use TABs and spaces consistently here. > "M-x tabify" is your friend. Actually, I blame Emacs for this one - when I justify (M-q) it plays havoc with my tabbing, and is otherwise inconsistent. This file could use some serious tabification; I'll do it in a separate pass, later. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer