* [PATCH] Don't include <malloc.h>
@ 2004-02-18 17:25 Mark Kettenis
2004-02-18 18:38 ` Andrew Cagney
0 siblings, 1 reply; 2+ messages in thread
From: Mark Kettenis @ 2004-02-18 17:25 UTC (permalink / raw)
To: gdb-patches
Including <malloc.h> is a no-no. The FreeBSD <malloc.h> makes GCC
warn about its usage ("use <stdlib.h> instead") which makes a compile
with -Werror fail. This stuff should be handled properly by our
"defs.h" anyway.
Committed as obvious,
Mark
Index: ChangeLog
from Mark Kettenis <kettenis@gnu.org>
* tui/tui.c: Don't include <malloc.h>.
Index: tui/tui.c
===================================================================
RCS file: /cvs/src/src/gdb/tui/tui.c,v
retrieving revision 1.46
diff -u -p -r1.46 tui.c
--- tui/tui.c 10 Feb 2004 19:08:19 -0000 1.46
+++ tui/tui.c 18 Feb 2004 17:22:18 -0000
@@ -25,7 +25,6 @@
#include <stdio.h>
#include <stdlib.h>
#include <ctype.h>
-#include <malloc.h>
#ifdef HAVE_TERM_H
#include <term.h>
#endif
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Don't include <malloc.h>
2004-02-18 17:25 [PATCH] Don't include <malloc.h> Mark Kettenis
@ 2004-02-18 18:38 ` Andrew Cagney
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cagney @ 2004-02-18 18:38 UTC (permalink / raw)
To: Mark Kettenis; +Cc: gdb-patches
> Including <malloc.h> is a no-no. The FreeBSD <malloc.h> makes GCC
> warn about its usage ("use <stdlib.h> instead") which makes a compile
> with -Werror fail. This stuff should be handled properly by our
> "defs.h" anyway.
>
> Committed as obvious,
Added to the ari.
Andrew
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2004-02-18 18:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-02-18 17:25 [PATCH] Don't include <malloc.h> Mark Kettenis
2004-02-18 18:38 ` Andrew Cagney
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox