* [PATCH] Watchpoint enhancement for S/390
@ 2004-02-18 16:44 Ulrich Weigand
2004-02-18 17:20 ` Mark Kettenis
0 siblings, 1 reply; 3+ messages in thread
From: Ulrich Weigand @ 2004-02-18 16:44 UTC (permalink / raw)
To: gdb-patches
Hello,
this patch improves hardware watchpoint handling on s390
a bit: by default, gdb only allows hw watchpoints on regions
of size less than the word size; on s390 we have no such
restriction, so we can allow arbitrary regions.
Tested on s390-ibm-linux and s390x-ibm-linux.
(I hope this is small enough so that no specific copyright
assignment is required ...)
Bye,
Ulrich
ChangeLog:
* config/s390/nm-linux.h (TARGET_REGION_OK_FOR_HW_WATCHPOINT): Define.
diff -c -p -r gdb-head-new/gdb/config/s390/nm-linux.h gdb-head/gdb/config/s390/nm-linux.h
*** gdb-head-new/gdb/config/s390/nm-linux.h Sun Jan 18 17:50:21 2004
--- gdb-head/gdb/config/s390/nm-linux.h Mon Jan 26 15:59:20 2004
*************** extern int s390_remove_watchpoint (CORE_
*** 47,52 ****
--- 47,53 ----
#define TARGET_HAS_HARDWARE_WATCHPOINTS
#define TARGET_CAN_USE_HARDWARE_WATCHPOINT(type, cnt, ot) 1
+ #define TARGET_REGION_OK_FOR_HW_WATCHPOINT(addr, len) 1
#define HAVE_CONTINUABLE_WATCHPOINT 1
#define STOPPED_BY_WATCHPOINT(w) \
--
Dr. Ulrich Weigand
weigand@informatik.uni-erlangen.de
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Watchpoint enhancement for S/390
2004-02-18 16:44 [PATCH] Watchpoint enhancement for S/390 Ulrich Weigand
@ 2004-02-18 17:20 ` Mark Kettenis
2004-02-18 18:09 ` Ulrich Weigand
0 siblings, 1 reply; 3+ messages in thread
From: Mark Kettenis @ 2004-02-18 17:20 UTC (permalink / raw)
To: weigand; +Cc: gdb-patches
From: Ulrich Weigand <weigand@i1.informatik.uni-erlangen.de>
Date: Wed, 18 Feb 2004 17:44:07 +0100 (CET)
Hello,
this patch improves hardware watchpoint handling on s390
a bit: by default, gdb only allows hw watchpoints on regions
of size less than the word size; on s390 we have no such
restriction, so we can allow arbitrary regions.
Tested on s390-ibm-linux and s390x-ibm-linux.
(I hope this is small enough so that no specific copyright
assignment is required ...)
Sure, please check this in.
ChangeLog:
* config/s390/nm-linux.h (TARGET_REGION_OK_FOR_HW_WATCHPOINT): Define.
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Watchpoint enhancement for S/390
2004-02-18 17:20 ` Mark Kettenis
@ 2004-02-18 18:09 ` Ulrich Weigand
0 siblings, 0 replies; 3+ messages in thread
From: Ulrich Weigand @ 2004-02-18 18:09 UTC (permalink / raw)
To: Mark Kettenis; +Cc: weigand, gdb-patches
Mark Kettenis wrote:
> Sure, please check this in.
Unfortunately I do not have CVS write privileges to the src repository ...
Bye,
Ulrich
--
Dr. Ulrich Weigand
weigand@informatik.uni-erlangen.de
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2004-02-18 18:09 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-02-18 16:44 [PATCH] Watchpoint enhancement for S/390 Ulrich Weigand
2004-02-18 17:20 ` Mark Kettenis
2004-02-18 18:09 ` Ulrich Weigand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox