From: Daniel Jacobowitz <drow@false.org>
To: Andrew Cagney <cagney@gnu.org>
Cc: Andreas Schwab <schwab@suse.de>, gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc] v2 bigcore.exp
Date: Mon, 16 Feb 2004 19:49:00 -0000 [thread overview]
Message-ID: <20040216194921.GA9601@nevyn.them.org> (raw)
In-Reply-To: <403111FF.3040700@gnu.org>
On Mon, Feb 16, 2004 at 01:54:55PM -0500, Andrew Cagney wrote:
> >Andrew Cagney <cagney@gnu.org> writes:
> >
> >
> >>+ /* Compute an initial chunk size. The math is dodgy but it works
> >>+ for the moment. Perhaphs there's a constant around somewhere. */
> >>+ {
> >>+ size_t tmp;
> >>+ for (tmp = 1; tmp > 0; tmp <<= 1)
> >>+ max_chunk_size = tmp;
> >
> >
> >max_chunk_size = ~((size_t) -1 >> 1);
>
> What's to stop the right shift smearing the sign bit?
>
> (I've just checked in the current test, we can fix this once we know a
> better equation).
Size_t is guaranteed to be unsigned, so it can't, afaict.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
prev parent reply other threads:[~2004-02-16 19:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-13 17:07 Andrew Cagney
2004-02-13 20:58 ` Andreas Schwab
2004-02-16 18:55 ` Andrew Cagney
2004-02-16 19:49 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040216194921.GA9601@nevyn.them.org \
--to=drow@false.org \
--cc=cagney@gnu.org \
--cc=gdb-patches@sources.redhat.com \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox