From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12363 invoked by alias); 16 Feb 2004 19:49:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12300 invoked from network); 16 Feb 2004 19:49:23 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 16 Feb 2004 19:49:23 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1Asok5-0002gS-CN; Mon, 16 Feb 2004 14:49:21 -0500 Date: Mon, 16 Feb 2004 19:49:00 -0000 From: Daniel Jacobowitz To: Andrew Cagney Cc: Andreas Schwab , gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] v2 bigcore.exp Message-ID: <20040216194921.GA9601@nevyn.them.org> Mail-Followup-To: Andrew Cagney , Andreas Schwab , gdb-patches@sources.redhat.com References: <402D0438.6010203@gnu.org> <403111FF.3040700@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <403111FF.3040700@gnu.org> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-02/txt/msg00427.txt.bz2 On Mon, Feb 16, 2004 at 01:54:55PM -0500, Andrew Cagney wrote: > >Andrew Cagney writes: > > > > > >>+ /* Compute an initial chunk size. The math is dodgy but it works > >>+ for the moment. Perhaphs there's a constant around somewhere. */ > >>+ { > >>+ size_t tmp; > >>+ for (tmp = 1; tmp > 0; tmp <<= 1) > >>+ max_chunk_size = tmp; > > > > > >max_chunk_size = ~((size_t) -1 >> 1); > > What's to stop the right shift smearing the sign bit? > > (I've just checked in the current test, we can fix this once we know a > better equation). Size_t is guaranteed to be unsigned, so it can't, afaict. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer