Re: [PATCH] unify objfile obstacks (4/4)

Re: [PATCH] unify objfile obstacks (4/4)

[Michael Elizabeth Chastain]

Hi Elena,

Could you please keep the old pattern in there too?

It makes my task easier, because I run the test suite from gdb HEAD
against gdb from gdb HEAD and gdb from gdb 6.0, and compare the two.
If you delete the old pattern then I get a false FAIL -> PASS
transition.

You can mark it:

  -expect "..." {
    # old gdb 6.0
    PASS ...
  }

So that it will get pruned eventually.

Michael C

===

2004-02-06  Elena Zannoni  <ezannoni@redhat.com>

        * gdb.base/maint.exp: Update test to reflect
         obstack changes.

Re: [PATCH] unify objfile obstacks (4/4)

[Elena Zannoni]

Michael Elizabeth Chastain writes:
 > Hi Elena,
 > 
 > Could you please keep the old pattern in there too?
 > 

sure.


here is what I checked in:

Index: maint.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/maint.exp,v
retrieving revision 1.22
diff -u -p -r1.22 maint.exp
--- maint.exp   17 Dec 2003 05:43:46 -0000      1.22
+++ maint.exp   7 Feb 2004 23:20:40 -0000
@@ -191,6 +191,11 @@ gdb_expect  {
 send_gdb "maint print statistics\n"
 gdb_expect  {
         -re "Statistics for.*break.*Number of \"minimal\" symbols read.*Number
of \"partial\" symbols read.*Number of \"types\" defined.*Number of psym tables
\\(not yet expanded\\).*Number of symbol tables.*Number of symbol tables with line tables.*Number of symbol tables with blockvectors.*Total memory used for psymbol obstack.*Total memory used for psymbol cache.*Total memory used for symbol obstack.*Total memory used for type obstack.*$gdb_prompt $"\
+                        {
+                           # Old output for gdb 6.0 and earlier
+                           pass "maint print statistics"
+                       }
+        -re "Statistics for.*break.*Number of \"minimal\" symbols read.*Number
of \"partial\" symbols read.*Number of \"types\" defined.*Number of psym tables
\\(not yet expanded\\).*Number of symbol tables.*Number of symbol tables with line tables.*Number of symbol tables with blockvectors.*Total memory used for objfile obstack.*Total memory used for psymbol cache.*Total memory used for macro cache.*$gdb_prompt $"\
                         { pass "maint print statistics" }
         -re ".*$gdb_prompt $"       { fail "maint print statistics" }
         timeout         { fail "(timeout) maint print statistics" }

Re: [PATCH] unify objfile obstacks (4/4)

[Michael Elizabeth Chastain]

+                        {
+                           # Old output for gdb 6.0 and earlier
+                           pass "maint print statistics"
+                       }
+        -re "Statistics for.*break.*Number of \"minimal\" symbols read.*Number
of \"partial\" symbols read.*Number of \"types\" defined.*Number of psym tables
\\(not yet expanded\\).*Number of symbol tables.*Number of symbol tables with line tables.*Number of symbol tables with blockvectors.*Total memory used for objfile obstack.*Total memory used for psymbol cache.*Total memory used for macro cache.*$gdb_prompt $"\

Perfect!  Thanks Elena.

[PATCH] unify objfile obstacks (4/4)

[Elena Zannoni]

the testsuite needs a little update too.

2004-02-06  Elena Zannoni  <ezannoni@redhat.com>

        * gdb.base/maint.exp: Update test to reflect
         obstack changes.

Index: maint.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/maint.exp,v
retrieving revision 1.22
diff -u -p -r1.22 maint.exp
--- maint.exp   17 Dec 2003 05:43:46 -0000      1.22
+++ maint.exp   6 Feb 2004 20:34:02 -0000
@@ -1,4 +1,5 @@
-# Copyright 1998, 1999, 2000, 2001, 2002, 2003 Free Software Foundation, Inc.
+# Copyright 1998, 1999, 2000, 2001, 2002, 2003, 2004
+# Free Software Foundation, Inc.
  
 # This program is free software; you can redistribute it and/or modify
 # it under the terms of the GNU General Public License as published by
@@ -190,7 +191,7 @@ gdb_expect  {
  
 send_gdb "maint print statistics\n"
 gdb_expect  {
-        -re "Statistics for.*break.*Number of \"minimal\" symbols read.*Number of \"partial\" symbols read.*Number of \"types\" defined.*Number of psym tables \\(not yet expanded\\).*Number of symbol tables.*Number of symbol tables with line tables.*Number of symbol tables with blockvectors.*Total memory used for psymbol obstack.*Total memory used for psymbol cache.*Total memory used for symbol obstack.*Total memory used for type obstack.*$gdb_prompt $"\
+        -re "Statistics for.*break.*Number of \"minimal\" symbols read.*Number of \"partial\" symbols read.*Number of \"types\" defined.*Number of psym tables \\(not yet expanded\\).*Number of symbol tables.*Number of symbol tables with line tables.*Number of symbol tables with blockvectors.*Total memory used for objfile obstack.*Total memory used for psymbol cache.*Total memory used for macro cache.*$gdb_prompt $"\
                         { pass "maint print statistics" }
         -re ".*$gdb_prompt $"       { fail "maint print statistics" }
         timeout         { fail "(timeout) maint print statistics" }