Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Michael Elizabeth Chastain <mec.gnu@mindspring.com>
Cc: cagney@gnu.org, brobecker@gnat.com, gdb-patches@sources.redhat.com
Subject: Re: Problems with dejagnu and c++ tests...
Date: Wed, 04 Feb 2004 23:13:00 -0000	[thread overview]
Message-ID: <20040204231253.GA27811@nevyn.them.org> (raw)
In-Reply-To: <20040204230342.6FEEC4B364@berman.michael-chastain.com>

On Wed, Feb 04, 2004 at 06:03:42PM -0500, Michael Chastain wrote:
> > Which would mean that a GCC code-gen bug in malloc, or printf would 
> > block all ability to run the testsuite :-(
> 
> Ah, I see.
> 
> So don't use printf ... use write(2).

I think assuming we can compile and run is fine.  Output is an
absolutely no-show, however.  Take a look at how many of our supported
targets don't have any kind of remote file I/O capability - gdbserver,
for one.

> There are 310 *.exp files in the test suite.
> 84 of them use get_compiler_info.
> 47 of them actually use one of the tests:
>   test_compiler_info
>   gcc_compiled, hp_aCC_compiler, hp_cc_compiler
>   signed_keyword_not_used
> 
> (Hmmm, I feel an obvious change coming to 37 files).
> 
> 84 out of 310 is not even close to "all".
> 
> If I did the compiler checks up front instead of inside get_compiler_info,
> then the compiler checks would have to do something nice if
> gdb_compile failed, such as leave compiler_info set to "no-compiler"
> for the language that failed.

And we'd save duplicating the tests 84 times...

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2004-02-04 23:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-04 23:03 Michael Elizabeth Chastain
2004-02-04 23:13 ` Daniel Jacobowitz [this message]
  -- strict thread matches above, loose matches on Subject: below --
2004-02-04 23:50 Michael Elizabeth Chastain
2004-02-04 23:55 ` Daniel Jacobowitz
2004-02-04 22:31 Michael Elizabeth Chastain
2004-02-04 22:49 ` Andrew Cagney
2004-02-04 14:01 Michael Elizabeth Chastain
2004-02-04 15:41 ` Andrew Cagney
2004-02-04 12:50 Michael Elizabeth Chastain
2004-02-04 13:20 ` Joel Brobecker
2004-02-04 11:58 Joel Brobecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040204231253.GA27811@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=brobecker@gnat.com \
    --cc=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mec.gnu@mindspring.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox