* [PATCH] Fix gdb.arch/{gdb1291.c,gdb1431.c}
@ 2003-11-28 21:34 Fred Fish
2004-02-04 5:17 ` [PATCH] Resubmitted - " Fred Fish
0 siblings, 1 reply; 4+ messages in thread
From: Fred Fish @ 2003-11-28 21:34 UTC (permalink / raw)
To: gdb-patches; +Cc: fnf
Apparently the SH toolchain has changed recently to start adding
underbar prefixes. This patch allows resolution of the global
function symbols with either convention.
-Fred
2003-11-28 Fred Fish <fnf@redhat.com>
* gdb.arch/gdb1431.c: Add underbar prefixed version of global
function symbols.
* gdb.arch/gdb1291.c: Ditto.
Index: gdb.arch/gdb1291.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/gdb1291.c,v
retrieving revision 1.1
diff -c -p -r1.1 gdb1291.c
*** gdb.arch/gdb1291.c 3 Nov 2003 17:42:52 -0000 1.1
--- gdb.arch/gdb1291.c 28 Nov 2003 21:26:11 -0000
*************** main()
*** 29,34 ****
--- 29,35 ----
asm(".text\n"
" .align 5\n"
"sub:\n"
+ "_sub:\n"
" mov.l r14,@-r15\n"
" mov.w .STACK2,r3\n"
" sub r3,r15\n"
Index: gdb.arch/gdb1431.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/gdb1431.c,v
retrieving revision 1.1
diff -c -p -r1.1 gdb1431.c
*** gdb.arch/gdb1431.c 3 Nov 2003 17:42:52 -0000 1.1
--- gdb.arch/gdb1431.c 28 Nov 2003 21:26:12 -0000
*************** main()
*** 31,36 ****
--- 31,37 ----
asm(".text\n"
" .align 5\n"
"sub1:\n"
+ "_sub1:\n"
" mov.l r14,@-r15\n"
" add #-128,r15\n"
" add #-128,r15\n"
*************** asm(".text\n"
*** 48,53 ****
--- 49,55 ----
asm(".text\n"
" .align 5\n"
"sub2:\n"
+ "_sub2:\n"
" mov.l r14,@-r15\n"
" mov.w .STACK2,r3\n"
" sub r3,r15\n"
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Resubmitted - Fix gdb.arch/{gdb1291.c,gdb1431.c}
2003-11-28 21:34 [PATCH] Fix gdb.arch/{gdb1291.c,gdb1431.c} Fred Fish
@ 2004-02-04 5:17 ` Fred Fish
2004-02-04 14:22 ` Daniel Jacobowitz
0 siblings, 1 reply; 4+ messages in thread
From: Fred Fish @ 2004-02-04 5:17 UTC (permalink / raw)
To: gdb-patches; +Cc: fnf
On Friday 28 November 2003 14:33, Fred Fish wrote:
> Apparently the SH toolchain has changed recently to start adding
> underbar prefixes. This patch allows resolution of the global
> function symbols with either convention.
>
> -Fred
This patch never (AFAIK) got reviewed or approved so I'm resubmitting
it. Here is a fresh copy.
-Fred
2004-02-03 Fred Fish <fnf@redhat.com>
* gdb.arch/gdb1431.c: Add underbar prefixed version of global
function symbols.
* gdb.arch/gdb1291.c: Ditto.
Index: testsuite/gdb.arch/gdb1291.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/gdb1291.c,v
retrieving revision 1.1
diff -c -p -r1.1 gdb1291.c
*** testsuite/gdb.arch/gdb1291.c 3 Nov 2003 17:42:52 -0000 1.1
--- testsuite/gdb.arch/gdb1291.c 4 Feb 2004 04:59:51 -0000
*************** main()
*** 29,34 ****
--- 29,35 ----
asm(".text\n"
" .align 5\n"
"sub:\n"
+ "_sub:\n"
" mov.l r14,@-r15\n"
" mov.w .STACK2,r3\n"
" sub r3,r15\n"
Index: testsuite/gdb.arch/gdb1431.c
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.arch/gdb1431.c,v
retrieving revision 1.1
diff -c -p -r1.1 gdb1431.c
*** testsuite/gdb.arch/gdb1431.c 3 Nov 2003 17:42:52 -0000 1.1
--- testsuite/gdb.arch/gdb1431.c 4 Feb 2004 04:59:51 -0000
*************** main()
*** 31,36 ****
--- 31,37 ----
asm(".text\n"
" .align 5\n"
"sub1:\n"
+ "_sub1:\n"
" mov.l r14,@-r15\n"
" add #-128,r15\n"
" add #-128,r15\n"
*************** asm(".text\n"
*** 48,53 ****
--- 49,55 ----
asm(".text\n"
" .align 5\n"
"sub2:\n"
+ "_sub2:\n"
" mov.l r14,@-r15\n"
" mov.w .STACK2,r3\n"
" sub r3,r15\n"
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] Resubmitted - Fix gdb.arch/{gdb1291.c,gdb1431.c}
2004-02-04 5:17 ` [PATCH] Resubmitted - " Fred Fish
@ 2004-02-04 14:22 ` Daniel Jacobowitz
0 siblings, 0 replies; 4+ messages in thread
From: Daniel Jacobowitz @ 2004-02-04 14:22 UTC (permalink / raw)
To: Fred Fish; +Cc: gdb-patches
On Tue, Feb 03, 2004 at 10:16:37PM -0700, Fred Fish wrote:
> On Friday 28 November 2003 14:33, Fred Fish wrote:
> > Apparently the SH toolchain has changed recently to start adding
> > underbar prefixes. This patch allows resolution of the global
> > function symbols with either convention.
> >
> > -Fred
>
> This patch never (AFAIK) got reviewed or approved so I'm resubmitting
> it. Here is a fresh copy.
>
> -Fred
>
> 2004-02-03 Fred Fish <fnf@redhat.com>
>
> * gdb.arch/gdb1431.c: Add underbar prefixed version of global
> function symbols.
> * gdb.arch/gdb1291.c: Ditto.
This is OK.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Resubmitted - Fix gdb.arch/{gdb1291.c,gdb1431.c}
@ 2004-02-04 7:07 Michael Elizabeth Chastain
0 siblings, 0 replies; 4+ messages in thread
From: Michael Elizabeth Chastain @ 2004-02-04 7:07 UTC (permalink / raw)
To: fnf; +Cc: gdb-patches
Looks trivially okay to me, as long as you've tested it at least once.
But I don't have power to approve it.
Michael C
2004-02-03 Fred Fish <fnf@redhat.com>
* gdb.arch/gdb1431.c: Add underbar prefixed version of global
function symbols.
* gdb.arch/gdb1291.c: Ditto.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2004-02-04 14:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-11-28 21:34 [PATCH] Fix gdb.arch/{gdb1291.c,gdb1431.c} Fred Fish
2004-02-04 5:17 ` [PATCH] Resubmitted - " Fred Fish
2004-02-04 14:22 ` Daniel Jacobowitz
2004-02-04 7:07 Michael Elizabeth Chastain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox