From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc] Fix inside entry func call
Date: Tue, 03 Feb 2004 17:25:00 -0000 [thread overview]
Message-ID: <20040203172553.GA20758@nevyn.them.org> (raw)
In-Reply-To: <401F1E37.10007@gnu.org>
On Mon, Feb 02, 2004 at 11:06:15PM -0500, Andrew Cagney wrote:
> Hello,
>
> This, cleans up one part of a long dangling thread. Per:
> http://sources.redhat.com/ml/gdb-patches/2003-11/msg00462.html
> This modifies the unwind code so that it uses the test:
>
> + && get_frame_func (this_frame) == entry_point_address ()
>
> that that in place, the old inside_entry_func can be made static to
> blockframe.c. This should reduce Kevin's patch to just doco + frame.c
> tweaks.
>
> comments?
Please re-read that discussion. Particularly:
http://sources.redhat.com/ml/gdb-patches/2003-11/msg00459.html
in which I asked you to leave the call to inside_entry_func and change
its implementation. You asked for other legitimate uses of this
function, and I gave you some.
> (get_prev_frame): Instead of inside_entry_func, call
> get_frame_func and entry_point_address.
I still object to this change.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2004-02-03 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-03 4:06 Andrew Cagney
2004-02-03 17:25 ` Daniel Jacobowitz [this message]
2004-02-03 22:19 ` Andrew Cagney
2004-02-04 15:40 ` Daniel Jacobowitz
2004-02-04 16:30 ` Andrew Cagney
2004-02-04 16:43 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040203172553.GA20758@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox