From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5949 invoked by alias); 3 Feb 2004 17:25:55 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5917 invoked from network); 3 Feb 2004 17:25:54 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 3 Feb 2004 17:25:54 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1Ao4J8-0005SB-2Q for ; Tue, 03 Feb 2004 12:25:54 -0500 Date: Tue, 03 Feb 2004 17:25:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [patch/rfc] Fix inside entry func call Message-ID: <20040203172553.GA20758@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <401F1E37.10007@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <401F1E37.10007@gnu.org> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-02/txt/msg00054.txt.bz2 On Mon, Feb 02, 2004 at 11:06:15PM -0500, Andrew Cagney wrote: > Hello, > > This, cleans up one part of a long dangling thread. Per: > http://sources.redhat.com/ml/gdb-patches/2003-11/msg00462.html > This modifies the unwind code so that it uses the test: > > + && get_frame_func (this_frame) == entry_point_address () > > that that in place, the old inside_entry_func can be made static to > blockframe.c. This should reduce Kevin's patch to just doco + frame.c > tweaks. > > comments? Please re-read that discussion. Particularly: http://sources.redhat.com/ml/gdb-patches/2003-11/msg00459.html in which I asked you to leave the call to inside_entry_func and change its implementation. You asked for other legitimate uses of this function, and I gave you some. > (get_prev_frame): Instead of inside_entry_func, call > get_frame_func and entry_point_address. I still object to this change. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer