Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Fred Fish <fnf@ninemoons.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: gdb-patches@sources.redhat.com, fnf@redhat.com
Subject: Re: [RFA] Fix testsuite gdb.base/bang.exp to work with remote targets
Date: Mon, 02 Feb 2004 21:17:00 -0000	[thread overview]
Message-ID: <200402021416.53341.fnf@ninemoons.com> (raw)
In-Reply-To: <20040202210148.GA5510@nevyn.them.org>

On Monday 02 February 2004 14:01, Daniel Jacobowitz wrote:
> I would prefer this.  It also handles gdbserver correctly (restart the
> server, continue).

OK, here is a revised patch.  Note this also preserves the previous
behavior, discussed on gdb-patches for other proposed changes to
bang.exp, where nothing is allowed after the "Program exited
normally." message.

-Fred

2004-02-02  Fred Fish  <fnf@redhat.com>

	* gdb.base/bang.exp: Use gdb_run_cmd so this tests works with
	remote targets.  Update copyright years.

Index: gdb.base/bang.exp
===================================================================
RCS file: /cvs/src/src/gdb/testsuite/gdb.base/bang.exp,v
retrieving revision 1.1
diff -c -p -r1.1 bang.exp
*** gdb.base/bang.exp	24 Jun 2003 22:04:06 -0000	1.1
--- gdb.base/bang.exp	2 Feb 2004 21:11:55 -0000
***************
*** 1,4 ****
! # Copyright 2003 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
--- 1,4 ----
! # Copyright 2003, 2004 Free Software Foundation, Inc.
  
  # This program is free software; you can redistribute it and/or modify
  # it under the terms of the GNU General Public License as published by
*************** gdb_reinitialize_dir $srcdir/$subdir
*** 35,41 ****
  gdb_load ${binfile}
  
  # Verify that we can run the program and that it terminates normally.
- gdb_test "run" \
-          ".*Program exited normally\." \
-          "run program"
  
--- 35,47 ----
  gdb_load ${binfile}
  
  # Verify that we can run the program and that it terminates normally.
  
+ gdb_run_cmd
+ gdb_expect {
+     -re ".*Program exited normally\.\r\n$gdb_prompt $" {
+         pass "run program"
+     }
+     timeout {
+ 	fail "run program (timeout)"
+     }
+ }



  reply	other threads:[~2004-02-02 21:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-02-02 20:26 Fred Fish
2004-02-02 20:32 ` Daniel Jacobowitz
2004-02-02 20:56   ` Fred Fish
2004-02-02 21:01     ` Daniel Jacobowitz
2004-02-02 21:17       ` Fred Fish [this message]
2004-02-02 21:23         ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200402021416.53341.fnf@ninemoons.com \
    --to=fnf@ninemoons.com \
    --cc=drow@mvista.com \
    --cc=fnf@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox