From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1994 invoked by alias); 2 Feb 2004 21:17:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 1987 invoked from network); 2 Feb 2004 21:16:59 -0000 Received: from unknown (HELO mx1.redhat.com) (66.187.233.31) by sources.redhat.com with SMTP; 2 Feb 2004 21:16:59 -0000 Received: from int-mx2.corp.redhat.com (nat-pool-rdu-dmz.redhat.com [172.16.52.200] (may be forged)) by mx1.redhat.com (8.11.6/8.11.6) with ESMTP id i12LGwb26913 for ; Mon, 2 Feb 2004 16:16:58 -0500 Received: from potter.sfbay.redhat.com (potter.sfbay.redhat.com [172.16.27.15]) by int-mx2.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i12LGvM15143; Mon, 2 Feb 2004 16:16:57 -0500 Received: from 192.168.1.129 (vpn50-55.rdu.redhat.com [172.16.50.55]) by potter.sfbay.redhat.com (8.11.6/8.11.6) with ESMTP id i12LGtb23803; Mon, 2 Feb 2004 13:16:55 -0800 From: Fred Fish Reply-To: fnf@ninemoons.com To: Daniel Jacobowitz Subject: Re: [RFA] Fix testsuite gdb.base/bang.exp to work with remote targets Date: Mon, 02 Feb 2004 21:17:00 -0000 User-Agent: KMail/1.5.4 Cc: gdb-patches@sources.redhat.com, fnf@redhat.com References: <200402021326.08063.fnf@ninemoons.com> <200402021356.34295.fnf@ninemoons.com> <20040202210148.GA5510@nevyn.them.org> In-Reply-To: <20040202210148.GA5510@nevyn.them.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200402021416.53341.fnf@ninemoons.com> X-SW-Source: 2004-02/txt/msg00037.txt.bz2 On Monday 02 February 2004 14:01, Daniel Jacobowitz wrote: > I would prefer this. It also handles gdbserver correctly (restart the > server, continue). OK, here is a revised patch. Note this also preserves the previous behavior, discussed on gdb-patches for other proposed changes to bang.exp, where nothing is allowed after the "Program exited normally." message. -Fred 2004-02-02 Fred Fish * gdb.base/bang.exp: Use gdb_run_cmd so this tests works with remote targets. Update copyright years. Index: gdb.base/bang.exp =================================================================== RCS file: /cvs/src/src/gdb/testsuite/gdb.base/bang.exp,v retrieving revision 1.1 diff -c -p -r1.1 bang.exp *** gdb.base/bang.exp 24 Jun 2003 22:04:06 -0000 1.1 --- gdb.base/bang.exp 2 Feb 2004 21:11:55 -0000 *************** *** 1,4 **** ! # Copyright 2003 Free Software Foundation, Inc. # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by --- 1,4 ---- ! # Copyright 2003, 2004 Free Software Foundation, Inc. # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by *************** gdb_reinitialize_dir $srcdir/$subdir *** 35,41 **** gdb_load ${binfile} # Verify that we can run the program and that it terminates normally. - gdb_test "run" \ - ".*Program exited normally\." \ - "run program" --- 35,47 ---- gdb_load ${binfile} # Verify that we can run the program and that it terminates normally. + gdb_run_cmd + gdb_expect { + -re ".*Program exited normally\.\r\n$gdb_prompt $" { + pass "run program" + } + timeout { + fail "run program (timeout)" + } + }