Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Jeff Johnston <jjohnstn@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA]: pending breakpoint support  [2/3]
Date: Wed, 21 Jan 2004 22:20:00 -0000	[thread overview]
Message-ID: <20040121222044.GB3324@nevyn.them.org> (raw)
In-Reply-To: <400EE920.4050705@redhat.com>

On Wed, Jan 21, 2004 at 04:03:28PM -0500, Jeff Johnston wrote:
> The following makes changes to the testsuite to accomodate the pending 
> breakpoint support.
> A new test case has been added to test pending breakpoint support.
> 
> Ok to commit?

Needs a tweak.

> -gdb_test "b langs0" "Function \"langs0\" not defined\.|Breakpoint .* (deferred).*" \
> -    "break on nonexistent function in langs.exp"

This has an implicit "$gdb_prompt $" anchor.  All of the following
cases need something similar; for the pending case that means you
should replace send_gdb "n\n" with, probably, gdb_test "n" "" "break
on...".

> +gdb_test_multiple "break pendfunc1" "set pending breakpoint" {
> +     -re ".*Make breakpoint pending.*$" {

Similarly, don't do that.  As soon as expect's buffer is full, it will
try to match, and succeed; possibly leaving a pending $gdb_prompt for
another test to match, getting us hideously out of sync.  Match
whatever prompt you 


> +	-re "Make breakpoint pending.*y or n. $" { 
> +		send_gdb "n\n"; 
> +		fail "setting breakpoint at $function" ; 
> +		return 0
> +	}

[in lib/gdb.exp] ditto.


-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2004-01-21 22:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-21 21:03 Jeff Johnston
2004-01-21 22:20 ` Daniel Jacobowitz [this message]
2004-01-21 23:12   ` J. Johnston
2004-01-22  0:20     ` Daniel Jacobowitz
2004-01-22  1:08       ` J. Johnston
2004-01-22 22:40         ` Daniel Jacobowitz
2004-01-23  1:06           ` J. Johnston
2004-01-23 15:01             ` Daniel Jacobowitz
2004-01-21 22:20 Michael Elizabeth Chastain
2004-01-21 22:58 ` J. Johnston
2004-01-21 23:14   ` J. Johnston
2004-01-24  7:31 Michael Elizabeth Chastain
2004-01-24 10:36 ` Eli Zaretskii
2004-02-02 21:17   ` Jeff Johnston

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040121222044.GB3324@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jjohnstn@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox