From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22733 invoked by alias); 21 Jan 2004 22:20:47 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 22724 invoked from network); 21 Jan 2004 22:20:44 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 21 Jan 2004 22:20:44 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1AjQiK-0007M4-8U; Wed, 21 Jan 2004 17:20:44 -0500 Date: Wed, 21 Jan 2004 22:20:00 -0000 From: Daniel Jacobowitz To: Jeff Johnston Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA]: pending breakpoint support [2/3] Message-ID: <20040121222044.GB3324@nevyn.them.org> Mail-Followup-To: Jeff Johnston , gdb-patches@sources.redhat.com References: <400EE920.4050705@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <400EE920.4050705@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-01/txt/msg00598.txt.bz2 On Wed, Jan 21, 2004 at 04:03:28PM -0500, Jeff Johnston wrote: > The following makes changes to the testsuite to accomodate the pending > breakpoint support. > A new test case has been added to test pending breakpoint support. > > Ok to commit? Needs a tweak. > -gdb_test "b langs0" "Function \"langs0\" not defined\.|Breakpoint .* (deferred).*" \ > - "break on nonexistent function in langs.exp" This has an implicit "$gdb_prompt $" anchor. All of the following cases need something similar; for the pending case that means you should replace send_gdb "n\n" with, probably, gdb_test "n" "" "break on...". > +gdb_test_multiple "break pendfunc1" "set pending breakpoint" { > + -re ".*Make breakpoint pending.*$" { Similarly, don't do that. As soon as expect's buffer is full, it will try to match, and succeed; possibly leaving a pending $gdb_prompt for another test to match, getting us hideously out of sync. Match whatever prompt you > + -re "Make breakpoint pending.*y or n. $" { > + send_gdb "n\n"; > + fail "setting breakpoint at $function" ; > + return 0 > + } [in lib/gdb.exp] ditto. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer