Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Mark Kettenis <kettenis@chello.nl>
To: cagney@gnu.org
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfc] Give decr pc after break a default of zero
Date: Fri, 16 Jan 2004 16:24:00 -0000	[thread overview]
Message-ID: <200401161623.i0GGNsEF000356@elgar.kettenis.dyndns.org> (raw)
In-Reply-To: <40071B7A.3080106@gnu.org> (message from Andrew Cagney on Thu, 15 Jan 2004 18:00:10 -0500)

   Date: Thu, 15 Jan 2004 18:00:10 -0500
   From: Andrew Cagney <cagney@gnu.org>

   Almost all architectures are setting DECR_PC_AFTER_BREAK to zero, this 
   makes that value the default.

Yeah!

   The main exception is i386, and even that has an exception to the 
   exception - Neutrino.  For Neutrino I've left the set-to-zero as is so 
   that it's clear that it is overriding the i386.

Removing the set-to-zero for Neutrino would be wrong; it is essential
that we override the i386 default.  Personally I think the "NOTE" form
of the comment you added isn't really appropriate.  I'd prefer
something like:

   /* Neutrino rewinds to look more normal, so we have to override the
      i386 default value.  */

Since that explains why we override the i386 default value.  It's
probably a matter of taste, but I'd appreciate if you changes it that
way.

Mark


  reply	other threads:[~2004-01-16 16:24 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-15 23:00 Andrew Cagney
2004-01-16 16:24 ` Mark Kettenis [this message]
2004-01-17 15:36   ` Andrew Cagney
2004-01-18 15:08     ` Mark Kettenis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200401161623.i0GGNsEF000356@elgar.kettenis.dyndns.org \
    --to=kettenis@chello.nl \
    --cc=cagney@gnu.org \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox