From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17099 invoked by alias); 16 Jan 2004 16:24:03 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17044 invoked from network); 16 Jan 2004 16:24:01 -0000 Received: from unknown (HELO walton.kettenis.dyndns.org) (213.93.115.144) by sources.redhat.com with SMTP; 16 Jan 2004 16:24:01 -0000 Received: from elgar.kettenis.dyndns.org (elgar.kettenis.dyndns.org [192.168.0.2]) by walton.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i0GGNseT000246; Fri, 16 Jan 2004 17:23:54 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: from elgar.kettenis.dyndns.org (localhost [127.0.0.1]) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6) with ESMTP id i0GGNsBd000359; Fri, 16 Jan 2004 17:23:54 +0100 (CET) (envelope-from kettenis@elgar.kettenis.dyndns.org) Received: (from kettenis@localhost) by elgar.kettenis.dyndns.org (8.12.6p3/8.12.6/Submit) id i0GGNsEF000356; Fri, 16 Jan 2004 17:23:54 +0100 (CET) Date: Fri, 16 Jan 2004 16:24:00 -0000 Message-Id: <200401161623.i0GGNsEF000356@elgar.kettenis.dyndns.org> From: Mark Kettenis To: cagney@gnu.org CC: gdb-patches@sources.redhat.com In-reply-to: <40071B7A.3080106@gnu.org> (message from Andrew Cagney on Thu, 15 Jan 2004 18:00:10 -0500) Subject: Re: [patch/rfc] Give decr pc after break a default of zero References: <40071B7A.3080106@gnu.org> X-SW-Source: 2004-01/txt/msg00415.txt.bz2 Date: Thu, 15 Jan 2004 18:00:10 -0500 From: Andrew Cagney Almost all architectures are setting DECR_PC_AFTER_BREAK to zero, this makes that value the default. Yeah! The main exception is i386, and even that has an exception to the exception - Neutrino. For Neutrino I've left the set-to-zero as is so that it's clear that it is overriding the i386. Removing the set-to-zero for Neutrino would be wrong; it is essential that we override the i386 default. Personally I think the "NOTE" form of the comment you added isn't really appropriate. I'd prefer something like: /* Neutrino rewinds to look more normal, so we have to override the i386 default value. */ Since that explains why we override the i386 default value. It's probably a matter of taste, but I'd appreciate if you changes it that way. Mark