Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Michael Elizabeth Chastain <mec.gnu@mindspring.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa/testsuite] constvars.exp, volatile.exp: hp-ux
Date: Wed, 07 Jan 2004 22:40:00 -0000	[thread overview]
Message-ID: <20040107224041.GA2233@nevyn.them.org> (raw)
In-Reply-To: <20040107223849.B6ED24B35A@berman.michael-chastain.com>

On Wed, Jan 07, 2004 at 05:38:49PM -0500, Michael Chastain wrote:
> This patch improves constvars.exp and volatile.exp to work with
> the HP compilers on hp-ux.
> 
> First, there was some code to force use of the HP C++ compiler instead
> of the HP C compiler.  I killed that.  The user decides at a higher
> level which compilers to use for which languages.
> 
> That bit of code wasn't even helping because HP C++ returns a (valid)
> compiler error for constvars.c.  For the curious, this line is
> not valid C++:
> 
>       # Uninitialized const/reference member in class/aggregate.
>       struct crass { char * const ptr; } crass;
> 
> Since ptr itself is const, it can't be changed after it's initialized,
> so it must be initialized.
> 
> I'm not dealing with that right now.  gdb.base/*.c does not have to
> compile with a C++ compiler.
> 
> Second, I removed a duplicate call to get_compiler_info.  That's
> just cleanup.
> 
> Third, in local_compiler_xfail_check, I added setup_xfail for
> $hp_cc_compiler.  The HP Ansi C compiler does not emit const qualifiers,
> so this is really an XFAIL, a limitation in the external compiler.  I
> checked that by stepping through hpread.c by hand.
> 
> Tested on:
> 
>   native hppa2.0w-hp-hpux11.11, hp ansi c
> 
> Okay to commit?

Yes, this is fine.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2004-01-07 22:40 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-07 22:38 Michael Elizabeth Chastain
2004-01-07 22:40 ` Daniel Jacobowitz [this message]
2004-01-07 22:47 Michael Elizabeth Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040107224041.GA2233@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mec.gnu@mindspring.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox