From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2286 invoked by alias); 7 Jan 2004 22:40:43 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 2279 invoked from network); 7 Jan 2004 22:40:42 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 7 Jan 2004 22:40:42 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1AeMLx-0000ai-SE; Wed, 07 Jan 2004 17:40:41 -0500 Date: Wed, 07 Jan 2004 22:40:00 -0000 From: Daniel Jacobowitz To: Michael Elizabeth Chastain Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa/testsuite] constvars.exp, volatile.exp: hp-ux Message-ID: <20040107224041.GA2233@nevyn.them.org> Mail-Followup-To: Michael Elizabeth Chastain , gdb-patches@sources.redhat.com References: <20040107223849.B6ED24B35A@berman.michael-chastain.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040107223849.B6ED24B35A@berman.michael-chastain.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-01/txt/msg00180.txt.bz2 On Wed, Jan 07, 2004 at 05:38:49PM -0500, Michael Chastain wrote: > This patch improves constvars.exp and volatile.exp to work with > the HP compilers on hp-ux. > > First, there was some code to force use of the HP C++ compiler instead > of the HP C compiler. I killed that. The user decides at a higher > level which compilers to use for which languages. > > That bit of code wasn't even helping because HP C++ returns a (valid) > compiler error for constvars.c. For the curious, this line is > not valid C++: > > # Uninitialized const/reference member in class/aggregate. > struct crass { char * const ptr; } crass; > > Since ptr itself is const, it can't be changed after it's initialized, > so it must be initialized. > > I'm not dealing with that right now. gdb.base/*.c does not have to > compile with a C++ compiler. > > Second, I removed a duplicate call to get_compiler_info. That's > just cleanup. > > Third, in local_compiler_xfail_check, I added setup_xfail for > $hp_cc_compiler. The HP Ansi C compiler does not emit const qualifiers, > so this is really an XFAIL, a limitation in the external compiler. I > checked that by stepping through hpread.c by hand. > > Tested on: > > native hppa2.0w-hp-hpux11.11, hp ansi c > > Okay to commit? Yes, this is fine. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer