From: Daniel Jacobowitz <drow@mvista.com>
To: Michael Elizabeth Chastain <mec.gnu@mindspring.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfc/cp] method stub assertions
Date: Mon, 05 Jan 2004 01:56:00 -0000 [thread overview]
Message-ID: <20040105015608.GA28300@nevyn.them.org> (raw)
In-Reply-To: <20040105005048.A159C4B35A@berman.michael-chastain.com>
On Sun, Jan 04, 2004 at 07:50:48PM -0500, Michael Chastain wrote:
> I'm working on support for hp-ux aCC.
Good luck :)
I'll re-read your analysis tomorrow when I'm more awake, but:
> *************** evaluate_subexp_standard (struct type *e
> *** 996,1006 ****
> if (METHOD_PTR_IS_VIRTUAL (fnptr))
> {
> int fnoffset = METHOD_PTR_TO_VOFFSET (fnptr);
> ! struct type *basetype;
> struct type *domain_type =
> ! TYPE_DOMAIN_TYPE (TYPE_TARGET_TYPE (VALUE_TYPE (arg1)));
> int i, j;
> ! basetype = TYPE_TARGET_TYPE (VALUE_TYPE (arg2));
> if (domain_type != basetype)
> arg2 = value_cast (lookup_pointer_type (domain_type), arg2);
> basetype = TYPE_VPTR_BASETYPE (domain_type);
> --- 997,1011 ----
> if (METHOD_PTR_IS_VIRTUAL (fnptr))
> {
> int fnoffset = METHOD_PTR_TO_VOFFSET (fnptr);
> ! struct type *basetype =
> ! basetype = TYPE_TARGET_TYPE (VALUE_TYPE (arg2));
> struct type *domain_type =
> ! TYPE_DOMAIN_TYPE (TYPE_TARGET_TYPE (VALUE_TYPE (arg1)));
> int i, j;
> !
> ! gdb_assert (basetype != NULL);
> ! gdb_assert (domain_type != NULL);
> !
> if (domain_type != basetype)
> arg2 = value_cast (lookup_pointer_type (domain_type), arg2);
> basetype = TYPE_VPTR_BASETYPE (domain_type);
>
I was trying to figure out what you changed here and why the diff
seemed confusing. Take another look at the new definition of basetype;
you added a typo.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2004-01-05 1:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-05 11:50 [rfc/cp] take 2: method stubs asserts Michael Elizabeth Chastain
2004-01-05 0:50 ` [rfc/cp] method stub assertions Michael Elizabeth Chastain
2004-01-05 1:56 ` Daniel Jacobowitz [this message]
2004-01-05 19:23 ` Daniel Jacobowitz
-- strict thread matches above, loose matches on Subject: below --
2004-01-06 18:24 Michael Elizabeth Chastain
2004-01-06 19:02 ` Daniel Jacobowitz
2004-01-06 4:28 Michael Elizabeth Chastain
2004-01-06 4:43 ` Daniel Jacobowitz
2004-01-06 17:05 ` Daniel Jacobowitz
2004-01-06 18:41 ` David Carlton
2004-01-06 19:05 ` Daniel Jacobowitz
2004-01-06 0:12 Michael Elizabeth Chastain
2004-01-06 2:51 ` Daniel Jacobowitz
2004-01-05 20:51 Michael Elizabeth Chastain
2004-01-05 2:32 Michael Elizabeth Chastain
2004-01-05 2:33 ` Daniel Jacobowitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040105015608.GA28300@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
--cc=mec.gnu@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox