From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 8384 invoked by alias); 5 Jan 2004 01:56:14 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 8174 invoked from network); 5 Jan 2004 01:56:10 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 5 Jan 2004 01:56:10 -0000 Received: from drow by nevyn.them.org with local (Exim 4.30 #1 (Debian)) id 1AdJyS-0007Nq-IF; Sun, 04 Jan 2004 20:56:08 -0500 Date: Mon, 05 Jan 2004 01:56:00 -0000 From: Daniel Jacobowitz To: Michael Elizabeth Chastain Cc: gdb-patches@sources.redhat.com Subject: Re: [rfc/cp] method stub assertions Message-ID: <20040105015608.GA28300@nevyn.them.org> Mail-Followup-To: Michael Elizabeth Chastain , gdb-patches@sources.redhat.com References: <20040105005048.A159C4B35A@berman.michael-chastain.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20040105005048.A159C4B35A@berman.michael-chastain.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2004-01/txt/msg00081.txt.bz2 On Sun, Jan 04, 2004 at 07:50:48PM -0500, Michael Chastain wrote: > I'm working on support for hp-ux aCC. Good luck :) I'll re-read your analysis tomorrow when I'm more awake, but: > *************** evaluate_subexp_standard (struct type *e > *** 996,1006 **** > if (METHOD_PTR_IS_VIRTUAL (fnptr)) > { > int fnoffset = METHOD_PTR_TO_VOFFSET (fnptr); > ! struct type *basetype; > struct type *domain_type = > ! TYPE_DOMAIN_TYPE (TYPE_TARGET_TYPE (VALUE_TYPE (arg1))); > int i, j; > ! basetype = TYPE_TARGET_TYPE (VALUE_TYPE (arg2)); > if (domain_type != basetype) > arg2 = value_cast (lookup_pointer_type (domain_type), arg2); > basetype = TYPE_VPTR_BASETYPE (domain_type); > --- 997,1011 ---- > if (METHOD_PTR_IS_VIRTUAL (fnptr)) > { > int fnoffset = METHOD_PTR_TO_VOFFSET (fnptr); > ! struct type *basetype = > ! basetype = TYPE_TARGET_TYPE (VALUE_TYPE (arg2)); > struct type *domain_type = > ! TYPE_DOMAIN_TYPE (TYPE_TARGET_TYPE (VALUE_TYPE (arg1))); > int i, j; > ! > ! gdb_assert (basetype != NULL); > ! gdb_assert (domain_type != NULL); > ! > if (domain_type != basetype) > arg2 = value_cast (lookup_pointer_type (domain_type), arg2); > basetype = TYPE_VPTR_BASETYPE (domain_type); > I was trying to figure out what you changed here and why the diff seemed confusing. Take another look at the new definition of basetype; you added a typo. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer