Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: mec.gnu@mindspring.com (Michael Elizabeth Chastain)
To: gdb-patches@sources.redhat.com
Subject: [rfa/testsuite/PING] asm-source.exp: use UNTESTED
Date: Fri, 02 Jan 2004 20:57:00 -0000	[thread overview]
Message-ID: <20040102205748.641454B35A@berman.michael-chastain.com> (raw)

[Originally submitted 2003-12-18]

I'm walking through the gdb.sum file for native hppa2.0w-hp-hpux11.11,
cleaning up crap in the test suite so that I can see the condition of
gdb better.  So here's the first patch.

This patch changes asm-source.exp for architectures that aren't
implemented yet.  The existing code calls gdb_suppress_entire_file, a
nasty function that doesn't actually suppress any tests: it just forces
a lot of test results to FAIL.  So I get: 4 ERROR, 5 WARNING, 28 FAIL, 1
UNRESOLVED.

My patch just reports UNTESTED and then returns.

I think that UNTESTED is the right test result here.  The dejagnu doco
says:

  @item UNTESTED
  @kindex UNTESTED
  @cindex untested properties
  A test case is not yet complete, and in particular cannot yet produce a
  @code{PASS} or @code{FAIL}.  You can also use this outcome in dummy
  ``tests'' that note explicitly the absence of a real test case
  for a particular property.

If you want the output to be WARNING and then UNTESTED, I wouldn't
object.  Or if you want a FAIL in there too so that people who ignore
everything but FAIL would see it.  I think UNTESTED is completely right
for this situation, but I'm flexible about happens.

But the call to gdb_suppress_entire_file really must die.  I can't deal
with 4 ERROR, 5 WARNING, 28 FAIL, and 1 UNRESOLVED just because no one
has written the assembly language test yet.  And I'm not going to write
it yet because I have to deal with testing HP's compilers and assemblers
first; it can't be just another hunk of gnu assembly code with a few
opcodes changed.

I tested this on native hppa2.0w-hp-hpux11.11, with a result
of UNTESTED.

Okay to commit?

Michael C

2003-12-17  Michael Chastain  <mec.gnu@mindspring.com>

	* gdb.asm/asm-source.exp: Return UNTESTED for platforms that
	have not implemented the assembly source test.

*** ORIGINAL-asm-source.exp	2003-12-18 01:15:58.000000000 -0500
--- asm-source.exp	2003-12-18 01:16:07.000000000 -0500
*************** switch -glob -- [istarget] {
*** 115,121 ****
  }
  
  if { "${asm-arch}" == "" } {
!     gdb_suppress_entire_file "Assembly source test -- not implemented for this target."
  }
  
  # On FreeBSD and NetBSD, crt1.o the final link will fail because of
--- 115,122 ----
  }
  
  if { "${asm-arch}" == "" } {
!     untested "assembly source test not implemented for this target"
!     return
  }
  
  # On FreeBSD and NetBSD, crt1.o the final link will fail because of


             reply	other threads:[~2004-01-02 20:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-01-02 20:57 Michael Elizabeth Chastain [this message]
2004-01-05 15:41 ` Andrew Cagney
2004-01-05 21:03 Michael Elizabeth Chastain
2004-01-05 21:49 ` Andrew Cagney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20040102205748.641454B35A@berman.michael-chastain.com \
    --to=mec.gnu@mindspring.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox