Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: Jeff Johnston <jjohnstn@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA]: breakpoint.c patch (prelude to pending breakpoint support)
Date: Thu, 11 Dec 2003 04:09:00 -0000	[thread overview]
Message-ID: <20031211040922.GA20136@nevyn.them.org> (raw)
In-Reply-To: <3FD7C458.2080404@redhat.com>

On Wed, Dec 10, 2003 at 08:11:52PM -0500, Jeff Johnston wrote:
> The following is a patch to centralize the test for an active-enabled 
> breakpoint.   This patch is in response to Daniel J's comments to split 
> up the pending-breakpoint support patch.   With pending breakpoint 
> support, the test will be modified to include a check for a pending 
> breakpoint.  This will simplify reviewing the last of the patches 
> required for pending-breakpoint support.
> 
> Ok to commit?
> 
> -- Jeff J.
> 
> 2003-12-10  Jeff Johnston  <jjohnstn@redhat.com>
> 
>    * breakpoint.c (breakpoint_enabled): New function to test whether 
> breakpoint is
>    active and enabled.
>    ( insert_bp_location, insert_breakpoints): Call new function to test
>    for enabled breakpoint.
>    (remove_breakpoint, breakpoint_here_p): Ditto.
>    (breakpoint_thread_match): Ditto.
>    (bpstat_should_step, bpstat_have_active_hw_watchpoints): Ditto.
>    (disable_breakpoints_in_shlibs): Ditto.
>    (hw_watchpoint_used_count): Ditto.
>    (disable_watchpoints_before_interactive_call_start): Ditto.
>    (breakpoint_re_set_one): Ditto.
>    (bpstat_stop_status): Use new function and simplify test.

This is fine!  Thanks for splitting it up.


-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


  reply	other threads:[~2003-12-11  4:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-12-11  1:11 Jeff Johnston
2003-12-11  4:09 ` Daniel Jacobowitz [this message]
2003-12-11  6:00 ` Eli Zaretskii
2003-12-11 14:21   ` Daniel Jacobowitz
2003-12-11 14:34     ` Eli Zaretskii
2003-12-12 19:05       ` J. Johnston
2003-12-11 20:36     ` Jim Blandy
2003-12-12  2:51       ` Daniel Jacobowitz
2003-12-12  6:18       ` Jim Blandy
2003-12-11 16:32   ` J. Johnston
2003-12-11 17:20     ` Eli Zaretskii
2003-12-11 19:33       ` J. Johnston
2003-12-11 19:50         ` Daniel Jacobowitz
2003-12-12 16:58         ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031211040922.GA20136@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jjohnstn@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox