From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7073 invoked by alias); 11 Dec 2003 04:09:24 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7057 invoked from network); 11 Dec 2003 04:09:23 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 11 Dec 2003 04:09:23 -0000 Received: from drow by nevyn.them.org with local (Exim 4.24 #1 (Debian)) id 1AUI8h-0005FP-2v; Wed, 10 Dec 2003 23:09:23 -0500 Date: Thu, 11 Dec 2003 04:09:00 -0000 From: Daniel Jacobowitz To: Jeff Johnston Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA]: breakpoint.c patch (prelude to pending breakpoint support) Message-ID: <20031211040922.GA20136@nevyn.them.org> Mail-Followup-To: Jeff Johnston , gdb-patches@sources.redhat.com References: <3FD7C458.2080404@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3FD7C458.2080404@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-12/txt/msg00309.txt.bz2 On Wed, Dec 10, 2003 at 08:11:52PM -0500, Jeff Johnston wrote: > The following is a patch to centralize the test for an active-enabled > breakpoint. This patch is in response to Daniel J's comments to split > up the pending-breakpoint support patch. With pending breakpoint > support, the test will be modified to include a check for a pending > breakpoint. This will simplify reviewing the last of the patches > required for pending-breakpoint support. > > Ok to commit? > > -- Jeff J. > > 2003-12-10 Jeff Johnston > > * breakpoint.c (breakpoint_enabled): New function to test whether > breakpoint is > active and enabled. > ( insert_bp_location, insert_breakpoints): Call new function to test > for enabled breakpoint. > (remove_breakpoint, breakpoint_here_p): Ditto. > (breakpoint_thread_match): Ditto. > (bpstat_should_step, bpstat_have_active_hw_watchpoints): Ditto. > (disable_breakpoints_in_shlibs): Ditto. > (hw_watchpoint_used_count): Ditto. > (disable_watchpoints_before_interactive_call_start): Ditto. > (breakpoint_re_set_one): Ditto. > (bpstat_stop_status): Use new function and simplify test. This is fine! Thanks for splitting it up. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer