From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [rfa/dwarf] Kill some more unnecessary global variables
Date: Tue, 02 Dec 2003 16:41:00 -0000 [thread overview]
Message-ID: <20031202164146.GD22220@nevyn.them.org> (raw)
In-Reply-To: <vt21xrxabys.fsf@zenia.home>
On Mon, Nov 24, 2003 at 12:54:51PM -0500, Jim Blandy wrote:
> Daniel Jacobowitz <drow@mvista.com> writes:
>
> > Now that we pass the section to dwarf2_read_section, we don't need to
> > pass the offset and size parameters also. After removing them, it turns out
> > that the global offset variables are only:
> > - passed to dwarf2_read_section
> > - tested for non-zero-ness to indicate presence of the section
> > And testing the section pointer works just as well, so we can remove the
> > offsets.
> >
> > This is part of the global state in dwarf2read crusade. The remaining
> > section info is probably going to move into the objfile as per-objfile data,
> > but I wanted to prune the deadwood first.
> >
> > OK?
>
> Yes! Please commit.
Thanks, checked in now.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
prev parent reply other threads:[~2003-12-02 16:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-23 22:56 Daniel Jacobowitz
2003-11-24 17:55 ` Jim Blandy
2003-12-02 16:41 ` Daniel Jacobowitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031202164146.GD22220@nevyn.them.org \
--to=drow@mvista.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox