From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 9283 invoked by alias); 2 Dec 2003 16:41:50 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 9276 invoked from network); 2 Dec 2003 16:41:49 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 2 Dec 2003 16:41:49 -0000 Received: from drow by nevyn.them.org with local (Exim 4.24 #1 (Debian)) id 1ARDas-00012i-Oy for ; Tue, 02 Dec 2003 11:41:46 -0500 Date: Tue, 02 Dec 2003 16:41:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [rfa/dwarf] Kill some more unnecessary global variables Message-ID: <20031202164146.GD22220@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20031123225631.GA26113@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.1i X-SW-Source: 2003-12/txt/msg00052.txt.bz2 On Mon, Nov 24, 2003 at 12:54:51PM -0500, Jim Blandy wrote: > Daniel Jacobowitz writes: > > > Now that we pass the section to dwarf2_read_section, we don't need to > > pass the offset and size parameters also. After removing them, it turns out > > that the global offset variables are only: > > - passed to dwarf2_read_section > > - tested for non-zero-ness to indicate presence of the section > > And testing the section pointer works just as well, so we can remove the > > offsets. > > > > This is part of the global state in dwarf2read crusade. The remaining > > section info is probably going to move into the objfile as per-objfile data, > > but I wanted to prune the deadwood first. > > > > OK? > > Yes! Please commit. Thanks, checked in now. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer