From: Daniel Jacobowitz <drow@mvista.com>
To: Ben Elliston <bje@wasabisystems.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: NetBSD testsuite patch (revised)
Date: Mon, 24 Nov 2003 04:24:00 -0000 [thread overview]
Message-ID: <20031124042406.GA19674@nevyn.them.org> (raw)
In-Reply-To: <87he0v1lbu.fsf@wasabisystems.com>
On Sun, Nov 23, 2003 at 08:32:52PM +1100, Ben Elliston wrote:
> Here is a more complete patch that gets the asm-source.exp tests
> passing on NetBSD/i386. The rationale behind this change is to force
> the linker to pass `--entry _start' for all target systems, since the
> asmsrc.1 file hardwires the symbol name to `_start'. This simplifies
> things and makes it possible to remove the duplicated label __start in
> mips.inc.
>
> This patch supersedes my previous patch. Okay to commit?
I don't suppose you could test this on a mips-elf simulator target? I
believe asm-source works OK there. If it still does, this is OK.
> 2003-11-23 Ben Elliston <bje@wasabisystems.com>
>
> * gdb.asm/asm-source.exp: Make sure the final link succeeds on
> NetBSD as it does on FreeBSD. Modelled on a similar change by
> Mark Kettenis on 2003-05-30.
> (link-flags): Set to "--entry _start" regardless of target.
> Special linker flags are to be appended to $link-flags.
> * gdb.asm/mips.inc (gdbasm_startup): Remove __start label.
--
Daniel Jacobowitz
MontaVista Software Debian GNU/Linux Developer
next prev parent reply other threads:[~2003-11-24 4:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-23 9:32 Ben Elliston
2003-11-24 4:24 ` Daniel Jacobowitz [this message]
2003-11-26 1:21 ` Ben Elliston
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031124042406.GA19674@nevyn.them.org \
--to=drow@mvista.com \
--cc=bje@wasabisystems.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox