From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30372 invoked by alias); 24 Nov 2003 04:24:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 30365 invoked from network); 24 Nov 2003 04:24:07 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 24 Nov 2003 04:24:07 -0000 Received: from drow by nevyn.them.org with local (Exim 4.24 #1 (Debian)) id 1AO8Gc-000580-8W; Sun, 23 Nov 2003 23:24:06 -0500 Date: Mon, 24 Nov 2003 04:24:00 -0000 From: Daniel Jacobowitz To: Ben Elliston Cc: gdb-patches@sources.redhat.com Subject: Re: NetBSD testsuite patch (revised) Message-ID: <20031124042406.GA19674@nevyn.them.org> Mail-Followup-To: Ben Elliston , gdb-patches@sources.redhat.com References: <87he0v1lbu.fsf@wasabisystems.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87he0v1lbu.fsf@wasabisystems.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-11/txt/msg00512.txt.bz2 On Sun, Nov 23, 2003 at 08:32:52PM +1100, Ben Elliston wrote: > Here is a more complete patch that gets the asm-source.exp tests > passing on NetBSD/i386. The rationale behind this change is to force > the linker to pass `--entry _start' for all target systems, since the > asmsrc.1 file hardwires the symbol name to `_start'. This simplifies > things and makes it possible to remove the duplicated label __start in > mips.inc. > > This patch supersedes my previous patch. Okay to commit? I don't suppose you could test this on a mips-elf simulator target? I believe asm-source works OK there. If it still does, this is OK. > 2003-11-23 Ben Elliston > > * gdb.asm/asm-source.exp: Make sure the final link succeeds on > NetBSD as it does on FreeBSD. Modelled on a similar change by > Mark Kettenis on 2003-05-30. > (link-flags): Set to "--entry _start" regardless of target. > Special linker flags are to be appended to $link-flags. > * gdb.asm/mips.inc (gdbasm_startup): Remove __start label. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer