Re: [RFA] Delete another call to dwarf2read.c:decode_locdesc

[Daniel Jacobowitz <drow@mvista.com>]

On Wed, Nov 19, 2003 at 02:06:05AM -0500, Jim Blandy wrote:
> 
> Daniel Jacobowitz <drow@mvista.com> writes:
> > The global variables set according to the DW_OP_frame_base are no longer
> > used anywhere except decode_locdesc, and decode_locdesc is never called when
> > we should expect a frame-relative object; see the updated comments in the
> > patch below.  This function is now only used for member offsets, etc.;
> > partial symbols (DW_TAG_variable only); and common blocks, which act as
> > global variables.  The partial symbol case should either be eliminated or
> > changed to use computed locations.  The common block case probably likewise.
> > And the remaining cases expect constants.
> > 
> > So DW_OP_breg* and DW_OP_fbreg are dead wood at this point and can be
> > removed from this function.  They're handled entirely in the LOC_COMPUTED
> > support code.
> > 
> > These happened to be next on my campaign to whack global state from the
> > dwarf2 reader; marching slowly down the file.  Tested on i386-linux/dwarf2.
> > OK?
> 
> Superb!  Please commit.

Thanks, checked in.  Next are, I think, the sections pointers and the
members of comp_unit_head which belong in dwarf2_cu.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer