From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6409 invoked by alias); 19 Nov 2003 15:09:16 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6355 invoked from network); 19 Nov 2003 15:09:15 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 19 Nov 2003 15:09:15 -0000 Received: from drow by nevyn.them.org with local (Exim 4.24 #1 (Debian)) id 1AMTxD-0003ya-H6 for ; Wed, 19 Nov 2003 10:09:15 -0500 Date: Wed, 19 Nov 2003 15:09:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [RFA] Delete another call to dwarf2read.c:decode_locdesc Message-ID: <20031119150915.GB14955@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20031119012558.GA4202@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.1i X-SW-Source: 2003-11/txt/msg00393.txt.bz2 On Wed, Nov 19, 2003 at 02:06:05AM -0500, Jim Blandy wrote: > > Daniel Jacobowitz writes: > > The global variables set according to the DW_OP_frame_base are no longer > > used anywhere except decode_locdesc, and decode_locdesc is never called when > > we should expect a frame-relative object; see the updated comments in the > > patch below. This function is now only used for member offsets, etc.; > > partial symbols (DW_TAG_variable only); and common blocks, which act as > > global variables. The partial symbol case should either be eliminated or > > changed to use computed locations. The common block case probably likewise. > > And the remaining cases expect constants. > > > > So DW_OP_breg* and DW_OP_fbreg are dead wood at this point and can be > > removed from this function. They're handled entirely in the LOC_COMPUTED > > support code. > > > > These happened to be next on my campaign to whack global state from the > > dwarf2 reader; marching slowly down the file. Tested on i386-linux/dwarf2. > > OK? > > Superb! Please commit. Thanks, checked in. Next are, I think, the sections pointers and the members of comp_unit_head which belong in dwarf2_cu. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer