Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Daniel Jacobowitz <drow@mvista.com>
To: gdb-patches@sources.redhat.com
Subject: Re: [PATCH] Prune some deadwood in dwarf2read.c:decode_locdesc
Date: Tue, 18 Nov 2003 21:52:00 -0000	[thread overview]
Message-ID: <20031118215221.GA5427@nevyn.them.org> (raw)
In-Reply-To: <20031117041950.GA22322@nevyn.them.org>

On Sun, Nov 16, 2003 at 11:19:50PM -0500, Daniel Jacobowitz wrote:
> This patch is obvious; barring comments I'll commit it in a day or two.
> Neither of these flags is checked any more now that LOC_COMPUTED is used.
> 
> The current status quo, by the way, is that there is one caller of
> decode_locdesc left which checks these global flags.  I believe that that
> call (for DW_AT_frame_base) is entirely dead and can be removed, after which
> it will be possible to simplify decode_locdesc even further.  But it's
> slightly less trivially dead, so I'll do that in a separate patch when I'm
> more awake.
> 
> After that, decode_locdesc will only ever be used in places where we expect
> a constant result - a global variable, a structure offset, et cetera. 
> Everything else has been converted to LOC_COMPUTED and LOC_COMPUTED_ARG.
> 
> -- 
> Daniel Jacobowitz
> MontaVista Software                         Debian GNU/Linux Developer
> 
> 2003-11-16  Daniel Jacobowitz  <drow@mvista.com>
> 
> 	* dwarf2read.c (optimized_out, islocal): Remove.
> 	(decode_locdesc): Update comments.  Don't set optimized_out
> 	or islocal.

Checked in.

-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer


      reply	other threads:[~2003-11-18 21:52 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-11-17  4:19 Daniel Jacobowitz
2003-11-18 21:52 ` Daniel Jacobowitz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20031118215221.GA5427@nevyn.them.org \
    --to=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox