From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24507 invoked by alias); 18 Nov 2003 21:52:25 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 24496 invoked from network); 18 Nov 2003 21:52:24 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 18 Nov 2003 21:52:24 -0000 Received: from drow by nevyn.them.org with local (Exim 4.24 #1 (Debian)) id 1AMDlm-0001mM-CC for ; Tue, 18 Nov 2003 16:52:22 -0500 Date: Tue, 18 Nov 2003 21:52:00 -0000 From: Daniel Jacobowitz To: gdb-patches@sources.redhat.com Subject: Re: [PATCH] Prune some deadwood in dwarf2read.c:decode_locdesc Message-ID: <20031118215221.GA5427@nevyn.them.org> Mail-Followup-To: gdb-patches@sources.redhat.com References: <20031117041950.GA22322@nevyn.them.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20031117041950.GA22322@nevyn.them.org> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-11/txt/msg00384.txt.bz2 On Sun, Nov 16, 2003 at 11:19:50PM -0500, Daniel Jacobowitz wrote: > This patch is obvious; barring comments I'll commit it in a day or two. > Neither of these flags is checked any more now that LOC_COMPUTED is used. > > The current status quo, by the way, is that there is one caller of > decode_locdesc left which checks these global flags. I believe that that > call (for DW_AT_frame_base) is entirely dead and can be removed, after which > it will be possible to simplify decode_locdesc even further. But it's > slightly less trivially dead, so I'll do that in a separate patch when I'm > more awake. > > After that, decode_locdesc will only ever be used in places where we expect > a constant result - a global variable, a structure offset, et cetera. > Everything else has been converted to LOC_COMPUTED and LOC_COMPUTED_ARG. > > -- > Daniel Jacobowitz > MontaVista Software Debian GNU/Linux Developer > > 2003-11-16 Daniel Jacobowitz > > * dwarf2read.c (optimized_out, islocal): Remove. > (decode_locdesc): Update comments. Don't set optimized_out > or islocal. Checked in. -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer