From: mec.gnu@mindspring.com (Michael Elizabeth Chastain)
To: gdb-patches@sources.redhat.com
Subject: [patch] mips-tdep.c: delete msymbol_size
Date: Tue, 11 Nov 2003 21:05:00 -0000 [thread overview]
Message-ID: <20031111210602.6F6484B361@berman.michael-chastain.com> (raw)
Whoops, I left a loose edge in my last patch.
mips-tdep.c has a function msymbol_size which returns the size
of the symbol by extracting it from MSYMBOL_INFO. Well, that
information is no longer in MSYMBOL_INFO!
Fortunately this msymbol_size is not actually called anywhere
so I'm just going to kill it instead of doing the trivial rewrite
Call the MSYMBOL_SIZE macro if you want this information
(and it's available only on elf, which is how it's always worked).
I also grepped all the other remaining uses of MSYMBOL_INFO
for similar problems.
I am committing this as an obvious fix.
Testing: I built a mips gdb, but didn't run the test suite.
2003-11-11 Michael Chastain <mec.gnu@mindspring.com>
* mips-tdep.c (msymbol_size): Delete.
Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.244
diff -u -r1.244 mips-tdep.c
--- mips-tdep.c 11 Nov 2003 20:04:52 -0000 1.244
+++ mips-tdep.c 11 Nov 2003 20:39:05 -0000
@@ -251,12 +251,6 @@
return (((long) MSYMBOL_INFO (msym) & 0x80000000) != 0);
}
-static long
-msymbol_size (struct minimal_symbol *msym)
-{
- return ((long) MSYMBOL_INFO (msym) & 0x7fffffff);
-}
-
/* XFER a value from the big/little/left end of the register.
Depending on the size of the value it might occupy the entire
register or just part of it. Make an allowance for this, aligning
next reply other threads:[~2003-11-11 21:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-11 21:05 Michael Elizabeth Chastain [this message]
2003-11-11 21:48 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20031111210602.6F6484B361@berman.michael-chastain.com \
--to=mec.gnu@mindspring.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox