From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4640 invoked by alias); 11 Nov 2003 21:05:58 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 4633 invoked from network); 11 Nov 2003 21:05:57 -0000 Received: from unknown (HELO hall.mail.mindspring.net) (207.69.200.60) by sources.redhat.com with SMTP; 11 Nov 2003 21:05:57 -0000 Received: from user-119a90a.biz.mindspring.com ([66.149.36.10] helo=berman.michael-chastain.com) by hall.mail.mindspring.net with esmtp (Exim 3.33 #1) id 1AJfi1-0001Cw-00 for gdb-patches@sources.redhat.com; Tue, 11 Nov 2003 16:05:57 -0500 Received: by berman.michael-chastain.com (Postfix, from userid 502) id 6F6484B361; Tue, 11 Nov 2003 16:06:02 -0500 (EST) To: gdb-patches@sources.redhat.com Subject: [patch] mips-tdep.c: delete msymbol_size Message-Id: <20031111210602.6F6484B361@berman.michael-chastain.com> Date: Tue, 11 Nov 2003 21:05:00 -0000 From: mec.gnu@mindspring.com (Michael Elizabeth Chastain) X-SW-Source: 2003-11/txt/msg00222.txt.bz2 Whoops, I left a loose edge in my last patch. mips-tdep.c has a function msymbol_size which returns the size of the symbol by extracting it from MSYMBOL_INFO. Well, that information is no longer in MSYMBOL_INFO! Fortunately this msymbol_size is not actually called anywhere so I'm just going to kill it instead of doing the trivial rewrite Call the MSYMBOL_SIZE macro if you want this information (and it's available only on elf, which is how it's always worked). I also grepped all the other remaining uses of MSYMBOL_INFO for similar problems. I am committing this as an obvious fix. Testing: I built a mips gdb, but didn't run the test suite. 2003-11-11 Michael Chastain * mips-tdep.c (msymbol_size): Delete. Index: mips-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/mips-tdep.c,v retrieving revision 1.244 diff -u -r1.244 mips-tdep.c --- mips-tdep.c 11 Nov 2003 20:04:52 -0000 1.244 +++ mips-tdep.c 11 Nov 2003 20:39:05 -0000 @@ -251,12 +251,6 @@ return (((long) MSYMBOL_INFO (msym) & 0x80000000) != 0); } -static long -msymbol_size (struct minimal_symbol *msym) -{ - return ((long) MSYMBOL_INFO (msym) & 0x7fffffff); -} - /* XFER a value from the big/little/left end of the register. Depending on the size of the value it might occupy the entire register or just part of it. Make an allowance for this, aligning