Re: RFA: switch to printf_unfiltered in symfile.c

[Daniel Jacobowitz <drow@mvista.com>]

On Wed, Oct 22, 2003 at 02:42:34PM -0400, J. Johnston wrote:
> The following patch switches over the majority of the printfs in symfile.c 
> to use printf_unfiltered.  This fixes a problem whereby if you attach to a 
> process that has a lot of dynamic library references, you will get page 
> breaks as it displays loading symbols messages.
> 
> I purposely left printf_filtered for info_ext_lang_command(), and 
> list_overlays_command() as I felt that a user may want to examine the 
> output and this should allow paging if necessary.
> 
> Ok to commit?
> 
> -- Jeff J.
> 
> 2003-10-22  Jeff Johnston  <jjohnstn@redhat.com>
> 
> 	* symfile.c (symbol_file_add_with_addrs_or_offsets): Switch to use
> 	printf_unfiltered instead of printf_filtered for output messages.
> 	(add_symbol_file_command): Ditto.
> 	(reread_symbols): Ditto.
> 	(overlay_auto_command): Ditto.
> 	(overlay_manual_command): Ditto.
> 	(overlay_off_command): Ditto.

Do any of our symtab maintainers have a comment on this patch?  I
vaguely remember that you agreed with it on gdb@, Jim?


-- 
Daniel Jacobowitz
MontaVista Software                         Debian GNU/Linux Developer