From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12394 invoked by alias); 28 Oct 2003 04:30:41 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 12385 invoked from network); 28 Oct 2003 04:30:40 -0000 Received: from unknown (HELO nevyn.them.org) (66.93.172.17) by sources.redhat.com with SMTP; 28 Oct 2003 04:30:40 -0000 Received: from drow by nevyn.them.org with local (Exim 4.24 #1 (Debian)) id 1AELV9-00079D-QB; Mon, 27 Oct 2003 23:30:39 -0500 Date: Tue, 28 Oct 2003 04:30:00 -0000 From: Daniel Jacobowitz To: "J. Johnston" Cc: gdb-patches@sources.redhat.com, jimb@redhat.com Subject: Re: RFA: switch to printf_unfiltered in symfile.c Message-ID: <20031028043039.GA27446@nevyn.them.org> Mail-Followup-To: "J. Johnston" , gdb-patches@sources.redhat.com, jimb@redhat.com References: <3F96CF9A.9080003@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3F96CF9A.9080003@redhat.com> User-Agent: Mutt/1.5.1i X-SW-Source: 2003-10/txt/msg00803.txt.bz2 On Wed, Oct 22, 2003 at 02:42:34PM -0400, J. Johnston wrote: > The following patch switches over the majority of the printfs in symfile.c > to use printf_unfiltered. This fixes a problem whereby if you attach to a > process that has a lot of dynamic library references, you will get page > breaks as it displays loading symbols messages. > > I purposely left printf_filtered for info_ext_lang_command(), and > list_overlays_command() as I felt that a user may want to examine the > output and this should allow paging if necessary. > > Ok to commit? > > -- Jeff J. > > 2003-10-22 Jeff Johnston > > * symfile.c (symbol_file_add_with_addrs_or_offsets): Switch to use > printf_unfiltered instead of printf_filtered for output messages. > (add_symbol_file_command): Ditto. > (reread_symbols): Ditto. > (overlay_auto_command): Ditto. > (overlay_manual_command): Ditto. > (overlay_off_command): Ditto. Do any of our symtab maintainers have a comment on this patch? I vaguely remember that you agreed with it on gdb@, Jim? -- Daniel Jacobowitz MontaVista Software Debian GNU/Linux Developer