Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [ob/PATCH]: include/elf/sh.h: Add missing SH symbols
@ 2003-10-23  9:58 Corinna Vinschen
  2003-10-23 16:18 ` Andrew Cagney
  0 siblings, 1 reply; 2+ messages in thread
From: Corinna Vinschen @ 2003-10-23  9:58 UTC (permalink / raw)
  To: binutils, gdb-patches

Hi,

my previous posted patch to add the new sh4a machine types to bfd was
missing a patch to include/elf/sh.h.  I've applied the below patch as
both, obvious and preapproved by Alexandre Oliva.

Corinna

2003-10-22  Alexandre Oliva  <aoliva@redhat.com>,
            Michael Snyder  <msnyder@redhat.com>

        * sh.h (EF_SH4A, EF_SH4AL_DSP, EF_SH4_NOFPU, EF_SH4A_NOFPU): New.
	(EF_SH_MERGE_MACH): Combine them.

Index: sh.h
===================================================================
RCS file: /cvs/src/src/include/elf/sh.h,v
retrieving revision 1.15
diff -u -p -r1.15 sh.h
--- sh.h	24 Sep 2003 02:27:56 -0000	1.15
+++ sh.h	23 Oct 2003 09:31:47 -0000
@@ -27,13 +27,18 @@
 #define EF_SH1		   1
 #define EF_SH2		   2
 #define EF_SH3		   3
-#define EF_SH_HAS_DSP(flags) ((flags) & 4)
+#define EF_SH_HAS_DSP(flags) (((flags) & EF_SH_MACH_MASK & ~3) == 4)
 #define EF_SH_DSP	   4
 #define EF_SH3_DSP	   5
+#define EF_SH4AL_DSP	   6
 #define EF_SH_HAS_FP(flags) ((flags) & 8)
 #define EF_SH3E		   8
 #define EF_SH4		   9
 #define EF_SH2E            11
+#define EF_SH4A		   12
+
+#define EF_SH4_NOFPU	   0x10
+#define EF_SH4A_NOFPU	   0x11
 
 /* This one can only mix in objects from other EF_SH5 objects.  */
 #define EF_SH5		  10
@@ -56,6 +61,20 @@
    : (((mach1) == EF_SH3E && (mach2) == EF_SH_UNKNOWN) \
       || ((mach2) == EF_SH3E && (mach1) == EF_SH_UNKNOWN)) \
    ? EF_SH4 \
+   /* ??? SH4?  Why not SH3E?  */ \
+   : ((((mach1) == EF_SH4_NOFPU || (mach1) == EF_SH4A_NOFPU) \
+       && EF_SH_HAS_DSP (mach2)) \
+      || (((mach2) == EF_SH4_NOFPU || (mach2) == EF_SH4A_NOFPU) \
+	  && EF_SH_HAS_DSP (mach1))) \
+   ? EF_SH4AL_DSP \
+   : ((mach1) == EF_SH4_NOFPU && EF_SH_HAS_FP (mach2)) \
+   ? ((mach2) < EF_SH4A) ? EF_SH4 : (mach2) \
+   : ((mach2) == EF_SH4_NOFPU && EF_SH_HAS_FP (mach1)) \
+   ? ((mach1) < EF_SH4A) ? EF_SH4 : (mach1) \
+   : ((mach1) == EF_SH4A_NOFPU && EF_SH_HAS_FP (mach2)) \
+   ? ((mach2) <= EF_SH4A) ? EF_SH4A : (mach2) \
+   : ((mach2) == EF_SH4A_NOFPU && EF_SH_HAS_FP (mach1)) \
+   ? ((mach1) <= EF_SH4A) ? EF_SH4A : (mach1) \
    : (((mach1) == EF_SH2E ? 7 : (mach1)) > ((mach2) == EF_SH2E ? 7 : (mach2)) \
       ? (mach1) : (mach2)))
 
-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [ob/PATCH]: include/elf/sh.h: Add missing SH symbols
  2003-10-23  9:58 [ob/PATCH]: include/elf/sh.h: Add missing SH symbols Corinna Vinschen
@ 2003-10-23 16:18 ` Andrew Cagney
  0 siblings, 0 replies; 2+ messages in thread
From: Andrew Cagney @ 2003-10-23 16:18 UTC (permalink / raw)
  To: Corinna Vinschen; +Cc: binutils, gdb-patches

> Hi,
> 
> my previous posted patch to add the new sh4a machine types to bfd was
> missing a patch to include/elf/sh.h.  I've applied the below patch as
> both, obvious and preapproved by Alexandre Oliva.

Thanks (noticed sh couldn't build late last night).

Andrew



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2003-10-23 16:18 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2003-10-23  9:58 [ob/PATCH]: include/elf/sh.h: Add missing SH symbols Corinna Vinschen
2003-10-23 16:18 ` Andrew Cagney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox